Bug 136599 - Create a single undo operation for find & replace
Summary: Create a single undo operation for find & replace
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: perf
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2020-09-09 10:12 UTC by Buovjaga
Modified: 2020-10-05 17:43 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Buovjaga 2020-09-09 10:12:56 UTC
Futher optimisation opportunity from bug 119286 comment 14

Quote:
"We create a ton of small UNDO objects. Again, a smarter thing to do would be to create a single UNDO operation."

This "is tricky because there are loops at multiple levels of the call stack, and it's not clear how the responsibilities are shared across the different calls."

Perf can be tested like so:
1. Open attachment 144181 [details]
2. Disable the automatic spell checking if enabled
3. In the Search for field put "." (a single period)
4. In the Replace with field put "x"
5. Make sure Whole words only is unchecked
6. Click Other Options to expand the dialog, and make sure Regular expressions is checked
7. Click Replace All