Bug 136613 - FILEOPEN: Images have incorrect position
Summary: FILEOPEN: Images have incorrect position
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Attila Bakos (NISZ)
URL:
Whiteboard: target:7.1.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Images layoutInCell
  Show dependency treegraph
 
Reported: 2020-09-09 16:40 UTC by Xisco Faulí
Modified: 2024-08-27 14:57 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.1 master (571.86 KB, image/png)
2020-09-09 16:40 UTC, Xisco Faulí
Details
Restored state in 7.1 after the patch (361.66 KB, image/png)
2020-09-25 11:25 UTC, Attila Bakos (NISZ)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-09-09 16:40:12 UTC
Created attachment 165327 [details]
Comparison MSO 2010 and LibreOffice 7.1 master

Steps to reproduce:
1. Open attachment 48879 [details] from bug 39056

-> The 2 images on the top right corner are incorrectly placed. See comparison image

Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: 63d4d3421fec5a4e9e88dcee2992cda38cc7452a
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-09-09 16:41:40 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=b6850bbe95418ecfde404be1696548f18d200c9b

author	Attila Bakos <bakos.attilakaroly@nisz.hu>	2020-08-06 13:49:43 +0200
committer	László Németh <nemeth@numbertext.org>	2020-08-21 23:48:33 +0200
commit b6850bbe95418ecfde404be1696548f18d200c9b (patch)
tree b6804b1b292b06389d8b58df9fe425e22f184af4
parent a6c2a87612a10d55fc59fa01e44d67d95505834f (diff)
tdf#106153 sw compatibility: fix textboxes exceeding the page

Bisected with: bibisect-linux64-7.1

Adding Cc: to Attila Bakos

Note: before the commit it wasn't perfect but it was much better than it is in master nowadays
Comment 2 Commit Notification 2020-09-24 16:29:07 UTC
Attila Bakos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7351a5028b18591306dfe18b34f6c751e565766e

tdf#136613 sw: fix picture position in tables

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Attila Bakos (NISZ) 2020-09-25 11:25:46 UTC
Created attachment 165834 [details]
Restored state in 7.1 after the patch

Far not the best solution however it seems like before my patch what caused this regression.
Comment 4 Xisco Faulí 2020-10-26 15:40:38 UTC
Verified in

Version: 7.1.0.0.alpha1+
Build ID: 0f0a5b63b19196f9463149a0a1991704c940efe2
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Attila Bakos, thanks for fixing this issue!!