Description: When any of SVG icons are selected in Options > View > Icon style, no icons appears in Styles tab of the sidebar. After returning to non-SVG Icon style, icons in Styles tab returns. Steps to Reproduce: 1.Open Writer document 2.Select Standard toolbar in View > User interface 3.Activate sidebar and select Styles tab 4.In Tools > Options > View > Icon style select any of SVG icons, e.g. Colibre (SVG) and press apply Actual Results: All icons in the top of Style tab disappear. After returning to non-SVG icons, e.g. Colibre, icons returns. Expected Results: After changing Icon style they should change but not disappear. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.0.1.2 Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: lv-LV (en_US.UTF-8); UI: en-US Calc: CL
Have you closed the module and reopened it?
(In reply to V Stuart Foote from comment #1) > Have you closed the module and reopened it? Yes, the same situation after restarting libreoffice.
(In reply to V Stuart Foote from comment #1) > Have you closed the module and reopened it? And in previous version icon changes right after applying changes, no need to restart the program.
Well next question is if you tried in Safe mode or a profile resets to default?
(In reply to V Stuart Foote from comment #4) > Well next question is if you tried in Safe mode or a profile resets to > default? Safe mode - the same results New profile - the same result
Created attachment 165627 [details] Change to an SVG icon theme populates the SB styles deck With OpenGL rendering enabled, can't confirm on Windows build (TB77 - 2020-09-08). Change to an SVG icon theme propagates themes icons into the SB Styles content panel.
likewise not on Windows release build Version: 7.0.1.2 (x64) Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452 CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: GL; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded
It looks like Linux only issue. In my case svg icons works fine on windows 7 installed in virtualbox. This regression doesn't affect 6.4.7.1.
I also have noticed this problem with LibreOffice 7.0.1.2: (a) On ArchLinux using Kernel 5.8.13-arch1-1 and GNOME 3.36.6 (b) On Debian Bullseye using Kernel 5.7.0-2-amd64 and GNOME 3.38.0
Reproduced in Version: 7.1.0.0.alpha0+ Build ID: a9976a958b2857e308c6598532151878615bfd9f CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Question to UX team: Should LibreOffice ask the user to restart after changing the icons ?
(In reply to Xisco Faulí from comment #11) > Question to UX team: Should LibreOffice ask the user to restart after > changing the icons ? I don't see the reason for this question. As it is mentioned above, nothing happens after restart, icons are just not visible.
(In reply to andis.lazdins from comment #12) > (In reply to Xisco Faulí from comment #11) > > Question to UX team: Should LibreOffice ask the user to restart after > > changing the icons ? > > I don't see the reason for this question. As it is mentioned above, nothing > happens after restart, icons are just not visible. oh, you are right
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=fe9a13dc0e6d1384416c2a2343223b33925fc925 author Caolán McNamara <caolanm@redhat.com> 2020-04-26 15:43:25 +0100 committer Caolán McNamara <caolanm@redhat.com> 2020-04-29 09:46:08 +0200 commit fe9a13dc0e6d1384416c2a2343223b33925fc925 (patch) tree a43a8ea0cc46407b8932dced64cf34d595f3b3e9 parent cf36fe5eb41910c26d58fb25e54ccf2e0ee01365 (diff) weld SfxTemplatePanelControl Bisected with: bibisect-linux64-7.0 Adding Cc: to Caolán McNamara
we start with an image url ending in .png but get the data in svg format, seeing as what we asked for ended in .png we assume its a png and use the specific pixbuf loader for that bisect just identifies the conversion to true gtk widgets real regression is probably commit 9e5cbcf90f15f46f84900a58bcaee437b98587f6 Date: Wed Dec 18 15:35:19 2019 +0200 load images by explicit type
(In reply to Caolán McNamara from comment #15) > we start with an image url ending in .png but get the data in svg format, > seeing as what we asked for ended in .png we assume its a png and use the > specific pixbuf loader for that > > bisect just identifies the conversion to true gtk widgets > real regression is probably > > commit 9e5cbcf90f15f46f84900a58bcaee437b98587f6 > Date: Wed Dec 18 15:35:19 2019 +0200 > > load images by explicit type Are the SVG icons no longer being parsed into PNG and stored in user profile? Did not think we had progressed on using SVG icon themes directly?
fixed in master with https://cgit.freedesktop.org/libreoffice/core/commit/?id=53e4e87d4bccdc12f6b87166b9123de627b844f9 (missing bug id in commit msg), backport to 7-0 in gerrit (with bug in commit msg)
Verified in Version: 7.1.0.0.alpha0+ Build ID: e897fdc46b07f211c4c96de103cfa494b645035a CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Caolán, thanks for fixing this issue!!
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/2a8cd72be8045ff90bad87acb884c5c96ca96ed2 tdf#136799 ImageTree::getImageStream may sub a req for a .png with svg data It will be available in 7.0.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Problem solved in 7.0.3. Thank you!