Bug 136830 - Imported PPTX group shapes positions are not correct
Summary: Imported PPTX group shapes positions are not correct
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: medium normal
Assignee: nd101
URL:
Whiteboard: target:7.1.0 target:7.0.3
Keywords: filter:pptx, regression
Depends on:
Blocks:
 
Reported: 2020-09-17 06:03 UTC by nd101
Modified: 2020-10-09 01:52 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Sample MSO document (13.77 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2020-09-17 06:05 UTC, nd101
Details
Correct renderring in MSO (3.85 KB, image/png)
2020-09-17 06:05 UTC, nd101
Details
Sample compared in MSO and LO (91.17 KB, image/png)
2020-09-24 11:18 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description nd101 2020-09-17 06:03:42 UTC
Description:
Attached MSO PPT document with group shapes are not imported correctly.

Steps to Reproduce:
1.Open the attached document
2.The shapes are not showing
3.

Actual Results:
The shapes are not showing

Expected Results:
It should show the shapes as in the attachement


Reproducible: Always


User Profile Reset: No



Additional Info:
We have the fix and it will be submitted
Comment 1 nd101 2020-09-17 06:05:17 UTC
Created attachment 165594 [details]
Sample MSO document
Comment 2 nd101 2020-09-17 06:05:49 UTC
Created attachment 165595 [details]
Correct renderring in MSO
Comment 3 Xisco Faulí 2020-09-17 08:50:16 UTC
Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: 6f1e02c96b887750f974c187a82ecd6236e6a435
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e
Comment 4 nd101 2020-09-17 09:18:02 UTC
Patch submitted https://gerrit.libreoffice.org/c/core/+/102895
Comment 5 Commit Notification 2020-09-18 17:04:45 UTC
nd101 committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b3f2fd983f0728893505d7ae12e3def924ab520f

tdf#136830 Fix: positions of group shapes of PPTX

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2020-09-18 20:12:51 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/489afd23ed8eff3b9df4c243b4e4c8fbc264b9d8

tdf#136830: sd_export_ooxml2: Add unittest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Timur 2020-09-24 11:18:03 UTC
Created attachment 165807 [details]
Sample compared in MSO and LO

This look fixed. No idea why not closed, I'll do it. 
Thanks Fong. (I hope it's OK to address you as Fong)
Comment 8 Timur 2020-09-24 11:34:58 UTC
This was fileopen bug. I also tested filesave, opened PPTX looks good in LO and MSO. 

Another bug is fileopen for PPT. I couldn't find it, I'll report separately.
Comment 9 nd101 2020-09-25 02:59:13 UTC
(In reply to Timur from comment #7)
> Created attachment 165807 [details]
> Sample compared in MSO and LO
> 
> This look fixed. No idea why not closed, I'll do it. 
> Thanks Fong. (I hope it's OK to address you as Fong)

Thanks! Fong is fine. :-)
Comment 10 Commit Notification 2020-09-25 10:54:41 UTC
nd101 committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/59657ae40d13bfe12d22989842c71da9ee870d94

tdf#136830 Fix: positions of group shapes of PPTX

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Xisco Faulí 2020-09-29 12:00:38 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: cd85546a2fbdade42f80fd3b6bd650791db9f32d
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: tr-TR (en_US.UTF-8); UI: en-US
Calc: threaded

@nd101, thanks for fixing this issue!
Comment 12 Timur 2020-09-29 12:25:09 UTC
Fong, I see you fix both PPTX and PPT (some devs don't). 
I opened a PPT version of this bug in See Also, if you are interested.
Comment 13 nd101 2020-10-09 01:52:07 UTC
(In reply to Timur from comment #12)
> Fong, I see you fix both PPTX and PPT (some devs don't). 
> I opened a PPT version of this bug in See Also, if you are interested.

Shape positions in a group can be tricky.. We will take a look at those two bugs you mentioned.