Description: The resolved state of a comment isn't saved.. Steps to Reproduce: 1. Open attached file 2. Set the comment to resolved 3. Save 4. Reload Actual Results: Resolved state disappears (not saved or not loaded) Expected Results: Should be the case, I assume Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: abcc4eb907661e07ad850ccce7eb06f129da4286 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Also in Version: 6.4.0.0.beta1+ (x64) Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL 6.2 doesn't have resolved mode
Adding bibisectrequest to find out who added the feature
@Regina A more or less superfluous question.. the 'Resolved comment" state is supported by the ODT format; right? Got implemented here: bug 119228
(In reply to Telesto from comment #3) > @Regina > A more or less superfluous question.. the 'Resolved comment" state is > supported by the ODT format; right? > > Got implemented here: bug 119228 No, it is not. You can check it easily yourself. Unpack the file and lock, whether it has a "loext" namespace. In this case you will see loext:resolved="true". You can look at https://wiki.documentfoundation.org/Development/ODF_Implementer_Notes/List_of_LibreOffice_ODF_Extensions. It should list all features of LibreOffice which do not belong to the standard. You can save the file in ODF 1.3 extended, but validate it with ODF 1.3 comforming. The validator will mark all things, which are not in the standard. Validator is at https://odfvalidator.org/ You should check, whether you have set your LibreOffice to save in ODF 1.3 extended (or ODF 1.2 extended in case of latest 6.4 version), otherwise you will loose the resolved mark.
Apparently the resolved state isn't written (not seeing anything in the ODT)
There's no attachment, so I don't know what your sample is like, Telesto. My experience is that if the comment is inserted at a single point, then the resolved state isn't saved, and if it's inserted for a text range, it's saved. Scott, could you clarify if that distinction was intentional, or perhaps an oversight? For now I'm confirming the above behavior with LO 7.1.0.0.alpha0+ (121771e37f7e2de41cd5643475861062bf25627b) / Ubuntu.
(In reply to Aron Budea from comment #6) > My experience is that if the comment is inserted at a single point, then the > resolved state isn't saved, and if it's inserted for a text range, it's > saved. That's indeed the issue. Except I didn't notice the difference between selection and single point
(In reply to Aron Budea from comment #6) > Scott, could you clarify if that distinction was intentional, or perhaps an > oversight? > No this wasn't an intentional distinction it was indeed an oversight.
See also is about two other missed area's.
(In reply to Telesto from comment #9) > See also is about two other missed area's. Better add that to bug 119228 's See Also, as they're unrelated to this issue.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f3b5356bdc51b03f9910ed544b8c17d6f919bc12 tdf#136861 ODT export: fix writing resolved state for non-ranged comments It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/d16aeba7dbbb8a4fe9564cbb0b895b103444f31a tdf#136861 ODT export: fix writing resolved state for non-ranged comments It will be available in 7.1.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/8c0157fc1c971e2ddf7f851510ecb94e61aa9eb9 tdf#136861 ODT export: fix writing resolved state for non-ranged comments It will be available in 7.0.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.