Bug 136878 - Move Validity drop-down list control inside cell
Summary: Move Validity drop-down list control inside cell
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Calc-UX Cell-Validity
  Show dependency treegraph
 
Reported: 2020-09-18 10:23 UTC by Roman Kuznetsov
Modified: 2022-02-10 13:37 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
GDocs vs Calc (167.54 KB, image/jpeg)
2020-09-18 10:25 UTC, Roman Kuznetsov
Details
GSheets with mixed content and content being added (1.97 KB, image/png)
2022-02-02 09:29 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2020-09-18 10:23:56 UTC
Description:
Move Validity drop-down list control inside cell

Steps to Reproduce:
1. Create a validity for cell with "Cell range" or "List" criteria
2. Select that cell
3. Look at drop-down list control => it's on right anf out of cell

I suggest move that control inside cell and make it always visibly as it's in Google Docs (look at screenshot from attach)

Actual Results:
drop-down list control is on right anf out of cell and it dissappears when you select another cell

Expected Results:
on right anf out of cell is inside cell and always visibly


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Roman Kuznetsov 2020-09-18 10:25:37 UTC
Created attachment 165656 [details]
GDocs vs Calc
Comment 2 Roman Kuznetsov 2020-09-18 10:43:26 UTC
advantages of implementation:

1. User will be always see these cells have some validity
2. Control will not hide info in cell right from current
Comment 3 Heiko Tietze 2020-09-18 11:51:19 UTC
Eike, what is the blocker for this?
Comment 4 Heiko Tietze 2022-02-02 09:29:58 UTC
Created attachment 177982 [details]
GSheets with mixed content and content being added

GSheet adds a margin to numbers so it starts after the control. Looks a bit odd for mixed content. Plus, GSheet always starts input from left while we come from right.  Sounds to me like a major refactoring and I wonder if it's worth the effort.

Code wise, ScGridWindow::GetListValButtonRect() calculates the button position which is drawn in ScGridWindow::DrawButtons().
Comment 5 Cor Nouws 2022-02-10 13:00:50 UTC
(In reply to Roman Kuznetsov from comment #2)
> advantages of implementation:
> 
> 1. User will be always see these cells have some validity

I do not see that as an advantage.

> 2. Control will not hide info in cell right from current

That is OK for me :)
Comment 6 Heiko Tietze 2022-02-10 13:37:26 UTC
Putting all together it is visually appealing but functionally not an improvement.
=> WF