Bug 137025 - EDITING Text Attributes dialog does not reflect Writer textframe properties of shapes
Summary: EDITING Text Attributes dialog does not reflect Writer textframe properties o...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Attila Bakos (NISZ)
URL:
Whiteboard: target:7.1.0
Keywords:
Depends on:
Blocks: Shape-Textbox
  Show dependency treegraph
 
Reported: 2020-09-25 12:26 UTC by NISZ LibreOffice Team
Modified: 2020-11-18 12:32 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer with a shape containing textbox and one without it (11.68 KB, application/vnd.oasis.opendocument.text)
2020-09-25 12:26 UTC, NISZ LibreOffice Team
Details
Screenshot of the original document in Writer (30.52 KB, image/png)
2020-09-25 12:26 UTC, NISZ LibreOffice Team
Details
Screenshot of the original document in Writer after applying changes to both shapes. Rectangle is unchanged. (33.04 KB, image/png)
2020-09-25 12:27 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-09-25 12:26:25 UTC
Created attachment 165840 [details]
Example file from Writer with a shape containing textbox and one without it

This problem occurs when a shape in Writer gets a text box added or when a docx file is opened with a shape.
In this situation the Format – Text box and shape – Text attributes dialog has no effect on the textframe of the shape.

Steps to reproduce:
    1. Open attached file, it contains a simple shape with textbox added and long text
    2. Select the shape and go to Format – Text box and shape – Text attributes
    3. Change the Spacing to borders fields value from the default 0 to 1 cm, enable Resize shape to fit text.
    4. Do the same with the rounded rectangle, which has no textbox added.

Actual results:
Nothing happens for the rectangle. Similarly nothing changes for DOCX-imported shapes such as in attachment #164060 [details] from bug #135569
The rounded rectangle correctly changes according to the new settings.

Expected results:
Text should start 1 cm from the left and right edge of the shape and it should be resized to make all of the text visible, like it happens for the rounded rectangle.

LibreOffice details:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: d237230ea014ba7a792c5ebccab28abe09868fc7
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 1 NISZ LibreOffice Team 2020-09-25 12:26:45 UTC
Created attachment 165841 [details]
Screenshot of the original document in Writer
Comment 2 NISZ LibreOffice Team 2020-09-25 12:27:03 UTC
Created attachment 165842 [details]
Screenshot of the original document in Writer after applying changes to both shapes. Rectangle is unchanged.
Comment 3 Commit Notification 2020-10-14 06:57:10 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/726c911b90b9a3170fa6b3a34bb952a8d2dbe148

tdf#137025 sw: apply textbox padding set in Text

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 NISZ LibreOffice Team 2020-11-18 12:32:20 UTC
Verified in:

Version: 7.1.0.0.alpha1+ (x64)
Build ID: ccd0e5f445d4a7d0e7aca6c23c02c61bf14510b2
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Thanks for fixing!