Created attachment 165875 [details] Wrong font color in font preview When you open Character settings, the font color of text preview doesn't respect dark theme. See attached image for more info. Version: 7.0.1.2 Build ID: 00(Build:2) CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: kf5 Locale: en-US (en_US.UTF-8); UI: en-US =7.0.1-1 Calc: threaded Operating System: Manjaro Linux KDE Plasma Version: 5.19.5 KDE Frameworks Version: 5.73.0 Qt Version: 5.15.0 Kernel Version: 5.4.64-1-MANJARO OS Type: 64-bit
I assume the preview showing the actual 'font color'. So how it looks like without dark theme.. There will be always some problem with showing the actual font settings & dark mode conversion. However much experience with dark theming.. so adding they UX (User Experience) departement
(In reply to Telesto from comment #1) > I assume the preview showing the actual 'font color'. So how it looks like > without dark theme.. > > There will be always some problem with showing the actual font settings & > dark mode conversion. However much experience with dark theming.. so adding > they UX (User Experience) departement Yeah you are right, that dialog controls also the color of the font and previews it, so the real problem comes from the background color of the rectangle where text is written, that rectangle fill color should be white. See attached image for more info.
Created attachment 165882 [details] wrong background color
Not necessarily set 'white', rather dialog should be aware of fg and bg colors of current theme and use for font preview and canvas color where possible. @Tomaž?
(In reply to V Stuart Foote from comment #4) > Not necessarily set 'white', rather dialog should be aware of fg and bg > colors of current theme and use for font preview and canvas color where > possible. > > @Tomaž? Not always white, but I mean it should uses the background color of text used on current selected text which is white in my case (like shown in screenshot).
Agree with Stuart that preview should use the application colors (page could be black with white font). Code pointer: SvxFontPrevWindow::ApplySettings() in svx/source/dialog/fontctrl.cxx
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6f3899b27156591e65f62649a92c727eb6f5dd03 Resolves tdf#137059 - Use application colors for font preview It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.