Bug 137165 - UI: Data label changes position after closing the Position and Size dialog
Summary: UI: Data label changes position after closing the Position and Size dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Balázs Varga
URL:
Whiteboard: target:7.1.0 target:7.0.3
Keywords: bibisected, bisected
Depends on:
Blocks:
 
Reported: 2020-09-30 17:26 UTC by Xisco Faulí
Modified: 2020-10-07 12:31 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-09-30 17:26:43 UTC
Steps to reproduce:
    1. Open attachment 165084 [details]
    2. Click on a single chart data label
    3. Format - Position and Size
    4. Click ok

-> The data label changes its position

Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: cd85546a2fbdade42f80fd3b6bd650791db9f32d
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2020-09-30 17:27:48 UTC
@Caolán, I thought you might be interested in this issue
Comment 2 Xisco Faulí 2020-09-30 17:28:59 UTC
The Position and Size dialog for Data labels was added in https://cgit.freedesktop.org/libreoffice/core/commit/?id=4223ff2be69f03e571464b0b09ad0d278918631b
Comment 3 Xisco Faulí 2020-09-30 17:40:38 UTC
Found this issue while working in a UItest for another issue, so I've already created a UItest for this issue: https://gerrit.libreoffice.org/c/core/+/103727
Comment 4 Balázs Varga 2020-10-01 09:37:56 UTC
(In reply to Xisco Faulí from comment #3)
> Found this issue while working in a UItest for another issue, so I've
> already created a UItest for this issue:
> https://gerrit.libreoffice.org/c/core/+/103727

Hi Xisco,

Thank you very much, for the UItest.

It will be the fix for this issue:
https://gerrit.libreoffice.org/c/core/+/103750
Comment 5 Commit Notification 2020-10-02 14:42:57 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/17b0eb43ac23cd82a06d54432a0ec22cffa5b3c7

tdf#137165 chart2: fix label position in Position and Size

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2020-10-06 13:45:34 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d15aa807be1c595dad9abc1dea04bb922570015a

tdf#137165: sc: Add UItest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2020-10-06 14:03:08 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/7f0d347eb879cd5859ee13a4c79d185a88b12fcc

tdf#137165 chart2: fix label position in Position and Size

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2020-10-07 12:31:52 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: 19a0fbf456129e011cb9ab9ab6ab730cba274bbd
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Balazs Varga, thanks for fixing this issue!!