Bug 137250 - with gtk3, keyboard ineffective in Format > Page > Page > Paper Format
Summary: with gtk3, keyboard ineffective in Format > Page > Page > Paper Format
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All Linux (All)
: medium minor
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0 target:7.0.3
Keywords:
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2020-10-04 22:24 UTC by Terrence Enger
Modified: 2020-10-21 13:40 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Terrence Enger 2020-10-04 22:24:54 UTC
STR
---

( 1) Start Calc with SAL_USE_VCLPLUGIN=gtk3

( 2) Take menu options Format > Page.  Program presents dialog "Page
     Style: Default Page"

( 3) Click tab Page.  Program shows "Paper Format": Format = A4,
     Width = 21.00 cm, Height = 29.70 cm.

( 4) Type "<alt>+F".  Program outlines the form type control showing A4.

( 5) Type "L".  The form type control shows Letter, but still
     Width = 21.00 and Height = 29.70 cm.

( 6) Click button <OK>.  Program returns focus to Calc window; the
     document-modified flag in status bar is set (amber down-arrow).

( 7) Take menu options Format > Page.  Program presents dialog "Page
     Style: Default Page", tab Page.

     Expected :  "Paper Format" > Format = Letter

     Observed :  "Paper Format" > Format = A4

For comparison, continuing on in the tab Page, this works:

( 8) In the paper format control, click on the down arrow to expand
     the list of paper formats.

( 9) Click form type Letter.  Program shows: Format = Letter,
     Width = 21.59 cm, Height = 27.94 cm.

(10) Click button <OK>.  Program returns focus to Calc window.

(11) Take menu options Format > Page.  Program presents dialog "Page
     Style: Default Page", tab Page with "Paper Format" >
     Format = Letter.

The behaviour in Writer is similar.  However, with
SAL_USE_VCLPLUGIN=gen, I do not see this problem in either
application.


I see this is on a local build of commit f266feae (2020-10-03), built
and running on debian-buster with a new user profile, configured:

    --with-vendor=Terrence Enger
    --with-jdk-home=/usr/lib/jvm/default-java
    --enable-split-debug
    --enable-gdb-index
    --enable-ld=gold
    --enable-option-checking=fatal
    #--enable-dbgutil
    --enable-debug
    --without-system-postgresql
    --without-myspell-dicts
    --with-extra-buildid
    --without-doxygen
    --with-external-tar=/home/terry/lo_hacking/git/src
    --without-package-format

I cannot make the problem happen with the latest version in
bibisect-linux-64-7.1.  I do not know what the difference is.
Comment 1 Commit Notification 2020-10-05 13:21:25 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/78f2eaafbcf595c5789531f4cf0b91586255bd94

tdf#137250 fire changed on typeahead in combobox without menu active

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Caolán McNamara 2020-10-05 13:50:26 UTC
fixed in master, backport to 7-0 in gerrit
Comment 3 Commit Notification 2020-10-05 15:13:22 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/0d7884362410104414e7d4e6c08ac9700b76c0d1

tdf#137250 fire changed on typeahead in combobox without menu active

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Terrence Enger 2020-10-06 13:39:35 UTC
I see the problem fixed in a local build.  Thank you, Caolán.

I am setting status VERI FIXE.
Comment 5 Commit Notification 2020-10-14 18:25:15 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b341758a6df28d2c2034fd2335924890ccb2b905

Related: tdf#137250 need signal-changed for ComboBoxText too

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2020-10-21 13:40:09 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/0431fae4d04ca892d11a860c2b11e4a6ca079031

Related: tdf#137250 need signal-changed for ComboBoxText too

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.