Created attachment 166103 [details] Example-screenshot (not the actual bug) Description: Deleting a comment sometimes disables the Comment-Navigator-dropdown. In this case, the Comment option stays unusually colorful (as there still are other comments left), the dropdown-triangle vanishes though. This results in there being no way of opening the dropdown-list of all comments. It's a dead menu-option now. How to reproduce: This is kind of a weird bug; not sure how to reproduce it, I managed to get it a few times in a new document, so it should be document independent... it's inconsistent though. Here's how I think you get it: 1. Create a new document. 2. Write any amount of text. 3. Create a few comments. 4. Open Navigator (You can do this earlier as well.) 5. Open the comment-dropdown in the navigator to see all the comments. 6. Retract the comment-dropdown. 7. Delete one of the Comments. (You might have to resolve/unresolve the comment first. No Idea whether this has any effect... might just be a placebo.) LO & System Information: Version: 7.0.1.2 Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: de-AT (en_US.UTF-8); UI: en-US Flatpak Calc: threaded
Created attachment 166104 [details] Bug-Screenshot
Created attachment 166154 [details] Sample ODT Steps: 1. Create a new document. 2. Write any amount of text. 3. Create a few comments. - or open attached ODT - 4. Open Navigator (You can do this earlier as well.) 5. Open the Comments dropdown in the navigator to see all the comments (with +). 6. Close the Comments dropdown (with -), mark remains on Headings in Navigator. 7. Delete one of the comments. 8. Undo. 9. Click on Comments in Navigator. See that there's no + in Comments. Repro 7.1+ in Windows.
There were 2 changes in 7.0. Easily seen bug, already after 7. Delete one of the comments: commit c3de7a2eb879c8ea82e78d7c29c541df93a68707 Date: Tue Mar 24 11:08:41 2020 +0100 source 5a2c0ab29719ac914d30d8789c0e386541702cbf previous source 70b9775af71b0e1a4b4d0760d2884631184db5ae author Caolán McNamara <caolanm@redhat.com> 2020-02-28 11:13:12 +0000 committer Caolán McNamara <caolanm@redhat.com> 2020-03-24 11:00:50 +0100 commit 5a2c0ab29719ac914d30d8789c0e386541702cbf (patch) tree a114088ae5b6d537de78db1745f9524e40baa714 parent 70b9775af71b0e1a4b4d0760d2884631184db5ae (diff) weld writer navigator 2nd change, seen also in 7.1+ is in Comment 2. Caolán, I guess it's also your welding, please see.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/242e90f16bc23eb85941b0bf13c5350375ce3837 Resolves: tdf#137274 comment node not expandable when there are comments It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
that appears to solve the problem, done in master and backport to 7-0 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/af26393963ed2ed19607d3f0cb42c0c6243d25c3 Resolves: tdf#137274 comment node not expandable when there are comments It will be available in 7.0.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b50b42b044b3e7a855dc72e017d5cba3d34aa1e3 tdf#137274: sw: Add UItest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.