Bug 137748 - [UI] <underlined character> not working in Statistics tab [Writer] [Calc]
Summary: [UI] <underlined character> not working in Statistics tab [Writer] [Calc]
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium minor
Assignee: Caolán McNamara
URL: https://ask.libreoffice.org/en/questi...
Whiteboard: target:7.4.0 target:7.3.4
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-25 21:07 UTC by LeroyG
Modified: 2022-05-22 15:49 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description LeroyG 2020-10-25 21:07:02 UTC
Description:
Pressing the keys Alt+<underlined character> do not select the values in the Statistics tab of the Properties dialog (although it works fine in the General tab).

Steps to Reproduce:
1. Choose menu File - Properties - Statistics tab.
2. Press Alt + P (for Pages).


Actual Results:
Nothing happens.

Expected Results:
Number of pages is selected (or characters might not show the underline).


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Not sure if earliest version affected is 4.4, but it is reported at https://ask.libreoffice.org/en/question/45105/ (dated 2015-01-18)

Version: 6.4.7.2 (x86)
Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; 
Locale: es-MX (es_MX); UI-Language: en-US
Calc: threaded
Comment 1 neuffbn 2020-11-24 21:58:54 UTC
Could reproduce in:
Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Also in:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: f313e27fb7f2d42247407e26e16f264e30f87ca5
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 2 LeroyG 2022-05-15 21:05:33 UTC
Reproducible with:

Version: 7.2.3.2 / LibreOffice Community
Build ID: 20(Build:2)
CPU threads: 1; OS: Linux 5.3; UI render: default; VCL: gtk3
Locale: es-MX (en_US.UTF-8); UI: en-US
Calc: threaded

Also do not work in the General tab.
Comment 3 sdc.blanco 2022-05-15 23:37:39 UTC
(In reply to LeroyG from comment #2)
> Also do not work in the General tab.
Do not reproduce with:

Version: 7.2.6.2 (x64) / LibreOffice Community
Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: threaded

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: cdf8e971d5d46df4bcab35a99c4254df9459213f
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL

Linux-specific?

Reproduce problem on Statistics tab (with both Versions).
Comment 4 Caolán McNamara 2022-05-16 10:00:10 UTC
I think the way to go here is to set the "selectable" property on the labels that are the targets of the mnemonics, that will do what happens in the "general" tab mentioned in comment #1 for gen. https://gerrit.libreoffice.org/c/core/+/134358/3 would do that

That doesn't work for gtk however, but that is arguable a bug, or at least something worth asking to be allowed, so logged https://gerrit.libreoffice.org/c/core/+/134358/3 for that
Comment 5 Commit Notification 2022-05-16 13:43:30 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2438c2e9bc2c700d03fa25936dc79c2658f3e71a

Related: tdf#137748 "Update" should have use-underline

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-05-16 15:57:31 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9cfaeb1e083208d7bfcd7a291455b1cc1ef200ea

tdf#137748 make keyboard accelerators functional in Statistics dialog

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-05-16 19:58:42 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/54f0c89ef7a93b12e6be67716bc55a47b69cb9a6

Related: tdf#137748 "Update" should have use-underline

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 sdc.blanco 2022-05-22 15:49:04 UTC
Verifying that Alt keyboard accelerators work now to select all items in Statistics tab and Update button with:

Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 09822cf77cdbe32b03553cd05154100b5f2591d0
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL