Bug 138030 - UI: Autocorrect exceptions - inconsistency pressing return closes the dialog (gen vs gtk)
Summary: UI: Autocorrect exceptions - inconsistency pressing return closes the dialog ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.2 all versions
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-06 09:14 UTC by Xisco Faulí
Modified: 2020-11-06 21:19 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-11-06 09:14:23 UTC
Steps to reproduce:
1. Open Writer
2. Tools - Auto correction -> Auto correct options -> Exceptions entry
3. Add some entry
4. Press return

the entry is added to the list but at the same time the dialog is closed. Not reproduced with GTK3

Reproduced in

Version: 7.1.0.0.alpha1+
Build ID: 9c8ed8c8526b9b696d0bf592eb7d963950f3cef4
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

and

Version: 5.2.0.0.alpha0+
Build ID: 13d4398820ded5914f635757865e258db2db2b57
CPU Threads: 4; OS Version: Linux 5.7; UI Render: default; 
Locale: en-US (en_US.UTF-8)
Comment 1 Xisco Faulí 2020-11-06 09:15:18 UTC
@Caolán, I thought you might be interested in this issue
Comment 2 Xisco Faulí 2020-11-06 09:15:47 UTC
not happening in the 'replace' tab
Comment 3 Caolán McNamara 2020-11-06 16:40:30 UTC
The gen behaviour is the designed behaviour (all the way back to OOo), where "activate" (pressing return) in the entries will press "new" if that option is available and otherwise trigger the default "ok" button. The same is true in replace, if "replace" is available then activate will trigger that, otherwise "ok"
Comment 4 Commit Notification 2020-11-06 21:13:53 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ca360dfe03882e27584ca38146940440b4891758

tdf#138030 be consistent wrt return triggering activate

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2020-11-06 21:15:05 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/35eb9708b0c8c90e37a042f387300342cae2af06

Related: tdf#138030 'activate' shouldn't add to the list...

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2020-11-06 21:15:15 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2e4657f57f8ac559a2f3be4286a4726465e88203

Related: tdf#138030 make 'except' page act like 'replace'

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2020-11-06 21:19:01 UTC
so, now both should work the same and if "new/replace" is sensitive that gets activated on return, otherwise ok.