Bug 138136 - EDITING Collapsing first of two consecutive headings does nothing
Summary: EDITING Collapsing first of two consecutive headings does nothing
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: Writer-Outline-Folding
  Show dependency treegraph
 
Reported: 2020-11-11 12:16 UTC by NISZ LibreOffice Team
Modified: 2023-07-28 23:10 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Word (26.64 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-11-11 12:16 UTC, NISZ LibreOffice Team
Details
The original document side by side in Word and Writer after collapsing first and second headings (62.17 KB, image/png)
2020-11-11 12:16 UTC, NISZ LibreOffice Team
Details
treat outline sub levels as content demo (2.09 MB, video/x-matroska)
2020-12-16 23:33 UTC, Jim Raykowski
Details
outline sub levels as content demo patch set 6 (1.32 MB, video/x-matroska)
2020-12-22 08:42 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-11-11 12:16:03 UTC
Created attachment 167199 [details]
Example file from Word

Attached user-made DOCX file contains some consecutive paragraphs that are formatted with Heading style and so are collapsable.
In Word collapsing the first paragraph collapses the second and the normal styled text, but in Writer it does nothing: only the second paragraphs collapsing hides the normal styled paragraph.

Steps to reproduce:
    1. Open attached file
    2. Enable Options – Writer – View – Show outline content visibility button
    3. Collapse any paragraph containing the Roman numerals.

Actual results:
Nothing is collapsed, but the icon on the left margin indicates so.

Expected results:
The second Heading paragraph and the subsequent normal text get collapsed.

LibreOffice details:
Version: 7.1.0.0.alpha1+ (x64)
Build ID: 00e5c63c35307faacf76a5e2ca7953c4208244ed
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 1 NISZ LibreOffice Team 2020-11-11 12:16:50 UTC
Created attachment 167200 [details]
The original document side by side in Word and Writer after collapsing first and second headings

@Jim I thought you might be interested in this one.
Comment 2 Jim Raykowski 2020-11-11 22:39:36 UTC
It seems to be working as expected. 

Az Utasítás hatálya has an outline level so collapsing the above outline will not hide it.

@Seth, Is the help page on using outline content visibility available? I wasn't able to find it yet.
Comment 3 Jim Raykowski 2020-11-12 02:15:46 UTC
(In reply to Jim Raykowski from comment #2)
> It seems to be working as expected. 
> 

I should have said, "It seems to be/is working as implemented." Maybe we should ask the UX team about this.
Comment 4 Buovjaga 2020-11-16 10:37:59 UTC
(In reply to Jim Raykowski from comment #3)
> I should have said, "It seems to be/is working as implemented." Maybe we
> should ask the UX team about this.

Let's ask them
Comment 5 Heiko Tietze 2020-11-17 10:07:38 UTC
(In reply to Jim Raykowski from comment #2)
> It seems to be working as expected. 

Using the Navigator one can Toggle or Hide All. And I'm sure we discussed which of the two is better suited for hierarchical information. Hopefully I argued for "Hide All" since content like this is always collapsed completely but you may had good arguments to implement the toggle feature. Don't remember what it was, though.
Comment 6 Jim Raykowski 2020-12-16 23:33:33 UTC
Created attachment 168246 [details]
treat outline sub levels as content demo

Here is effort that adds option to treat sub outline levels as content of upper levels. When this option is active, sub outline levels and their content will be hid or shown on upper level visibility toggle. 

https://gerrit.libreoffice.org/c/core/+/107815
Comment 7 Heiko Tietze 2020-12-17 10:52:05 UTC
(In reply to Jim Raykowski from comment #6)
> Created attachment 168246 [details]
> treat outline sub levels as content demo

Very nice! The new option is not effective unless the (experimental!) content visibility is checked. We should make this dependency clear and indent the new checkbox. Would also name it shorter, maybe "Including sub levels". The 'treat as content' is a bit unclear in respect to the opposite :-).

About experimental: Please take this into consideration. It's also a bit weird to have a frame label without content when experimental is off. So maybe we call it a productive feature now.
Comment 8 Jim Raykowski 2020-12-22 08:42:02 UTC
Created attachment 168404 [details]
outline sub levels as content demo patch set 6

Patch set 6 addresses naming and indentation for the the new checkbox and also hides the group label when experimental is off.
Comment 9 Jim Raykowski 2020-12-24 06:12:42 UTC
Let's give this patch set 6 a go and keep it experimental for now.
Comment 10 Commit Notification 2020-12-24 06:13:51 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c405bae468d887ec77dd3830b7678fcedc2debfd

tdf#138136 tdf#38093 add option to treat sub outline levels as content

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 NISZ LibreOffice Team 2021-01-25 14:17:07 UTC
Verified in:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 96bafa464ebdbce3ef04bec9beae5e745bb37794
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-GB
Calc: threaded

Thanks for fixing!