Bug 138281 - UI: Find all highlights even the text inside find toolbar (gtk3)
Summary: UI: Find all highlights even the text inside find toolbar (gtk3)
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-11-17 10:27 UTC by Xisco Faulí
Modified: 2021-08-11 06:08 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-11-17 10:27:52 UTC
This is a follow-up of bug 138232 only happening in GTK3

Steps to Reproduce:
1. Open Writer
2. Type: Hello ; Enter : Hello
3. CTRL+F
4. Type Hello
5. Press Enter -> Notice text not being higlighted
6. Click with they mouse on Find All (text in search bar highlighted to)

Actual Results:
Text in search bar highlighted

Version: 7.1.0.0.alpha1+
Build ID: 33381457503db841cdda3abb95ff3f96fb6e3e6c
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2020-11-17 10:29:14 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f4f0ea6a41e99e12812a791f732694c8e86acb8c

author	Jim Raykowski <raykowj@gmail.com>	2020-09-26 21:18:48 -0800
committer	Jim Raykowski <raykowj@gmail.com>	2020-09-30 05:22:02 +0200
commit	f4f0ea6a41e99e12812a791f732694c8e86acb8c (patch)
tree	6b6c6ef257024dc14b49f85893d6eaeb5e8892bb
parent	28ed472e4e15348cb9a7ee9b43a22b1c92836471 (diff)
tdf#137013 fix Writer find toolbar ui regressions

Bisected with: bibisect-linux64-7.1

Adding Cc: to Jim Raykowski
Comment 2 Xisco Faulí 2020-11-17 10:30:16 UTC
Hi Caolán, this issue is the same as bug 138232 but GTK3 only. I thought you might be interested
Comment 3 Commit Notification 2021-04-30 14:18:19 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c90792cf4309557981d1f89febeff9157fd93b0c

Related: tdf#138281 move grab_focus to ActivateFind

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Justin L 2021-08-11 06:08:42 UTC
Repro 7.3+ the fact that the search bar phrase is highlighted too for Find All.

However, I have never been able to reproduce the Enter not highlighting the first match in the document. (Perhaps point 5 only means "notice the search bar's text is not being highlighted" which has always been true.)

Assigned, but 7.2 patch was only "related" and didn't claim to fix the problem.