This is a follow-up of bug 138232 only happening in GTK3 Steps to Reproduce: 1. Open Writer 2. Type: Hello ; Enter : Hello 3. CTRL+F 4. Type Hello 5. Press Enter -> Notice text not being higlighted 6. Click with they mouse on Find All (text in search bar highlighted to) Actual Results: Text in search bar highlighted Version: 7.1.0.0.alpha1+ Build ID: 33381457503db841cdda3abb95ff3f96fb6e3e6c CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=f4f0ea6a41e99e12812a791f732694c8e86acb8c author Jim Raykowski <raykowj@gmail.com> 2020-09-26 21:18:48 -0800 committer Jim Raykowski <raykowj@gmail.com> 2020-09-30 05:22:02 +0200 commit f4f0ea6a41e99e12812a791f732694c8e86acb8c (patch) tree 6b6c6ef257024dc14b49f85893d6eaeb5e8892bb parent 28ed472e4e15348cb9a7ee9b43a22b1c92836471 (diff) tdf#137013 fix Writer find toolbar ui regressions Bisected with: bibisect-linux64-7.1 Adding Cc: to Jim Raykowski
Hi Caolán, this issue is the same as bug 138232 but GTK3 only. I thought you might be interested
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c90792cf4309557981d1f89febeff9157fd93b0c Related: tdf#138281 move grab_focus to ActivateFind It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Repro 7.3+ the fact that the search bar phrase is highlighted too for Find All. However, I have never been able to reproduce the Enter not highlighting the first match in the document. (Perhaps point 5 only means "notice the search bar's text is not being highlighted" which has always been true.) Assigned, but 7.2 patch was only "related" and didn't claim to fix the problem.
Dear Caolán McNamara, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assign it back to yourself if you're still working on this.
Steps to Reproduce: 1. Open Writer 2. Type: "Hello", Enter, "Hello" (whitout quotes, Enter is the key) 3. CTRL+F 4. Type "Hello" 5. Press Enter 6.a. Click with the mouse on Find All 6.b. Click with the mouse on the document text, and click on Find All Actual Results: After step 5. Only first Hello in document is highlighted, text in the Search bar is NOT higlighted -------------------- Versión: 6.4.7.2 (x64) Id. de compilación: 639b8ac485750d5696d7590a72ef1b496725cfb5 Subprocs. CPU: 4; SO: Windows 10.0 Build 17763; Repres. IU: predet.; VCL: win; Configuración regional: es-AR (es_AR); Idioma de IU: es-ES Calc: threaded Actual Results: After step 6.a. Both Hello in document are highlighted, text in search bar is NOT highlighted After step 6.b. Both Hello in document are highlighted, text in search bar is NOT highlighted -------------------- Version: 24.2.7.2 (X86_64) / LibreOffice Community Build ID: ee3885777aa7032db5a9b65deec9457448a91162 CPU threads: 4; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL: win Locale: es-MX (es_AR); UI: en-US Calc: threaded Version: 24.8.2.1 (X86_64) / LibreOffice Community Build ID: 0f794b6e29741098670a3b95d60478a65d05ef13 CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 17763); UI render: Skia/Raster; VCL: win Locale: es-MX (es_AR); UI: en-US Calc: threaded Actual Results: After step 6.a. Both Hello in document are highlighted, text in search bar is NOT highlighted After step 6.b. Both Hello in document are highlighted, text in search bar IS highlighted