Bug 138300 - Build error for 7.1.0.0.alpha0+ related to ICU
Summary: Build error for 7.1.0.0.alpha0+ related to ICU
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-17 23:44 UTC by arungiridhar
Modified: 2020-11-18 16:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description arungiridhar 2020-11-17 23:44:10 UTC
Description:
For dev sources checked out from git (commit de1ac1c349435a229aec8682f8f8a796c3ca4dc5), I get the following error when building:

libreoffice/external/icu/ExternalPackage_icu.mk:37: *** file workdir/UnpackedTarball/icu/source/lib/libicudata.so.67.1 does not exist in the tarball.  Stop.
make: *** [Makefile:282: build] Error 2

It looks like the ICU library was updated. The unpacked version is numbered libicudata,so.68.* but the makefile thinks it should be 67?

Steps to Reproduce:
1. Download the dev sources from git.

2. Call configure with the following options:

export CC="gcc"
export CXX="g++"
export CFLAGS="-march=znver2 -O3 -pipe "
export CXXFLAGS="$CFLAGS"
export PARALLELISM=6

./configure --srcdir=/home/myname/src/libreoffice --enable-option-checking=fatal --disable-fuzz-options --enable-lpsolve --enable-coinmp --enable-pdfimport --enable-pdfium --enable-mergelibs --disable-fuzzers --disable-epm --enable-odk --disable-dbgutil --disable-debug --disable-gdb-index --enable-optimized=yes --enable-runtime-optimizations --disable-compiler-plugins --disable-lto --enable-python=system --enable-ld=gold --enable-largefile --enable-ext-numbertext --enable-ext-nlpsolver --disable-ext-languagetool

3. Run make. Build error!

Actual Results:
libreoffice/external/icu/ExternalPackage_icu.mk:37: *** file workdir/UnpackedTarball/icu/source/lib/libicudata.so.67.1 does not exist in the tarball.  Stop.
make: *** [Makefile:282: build] Error 2



Expected Results:
Should have built normally.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+
Build ID: 93b1adf7442839dcfbf16660b1fbe1139f14a4d0
CPU threads: 12; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: en-US (en_US.utf8); UI: en-US
Calc: threaded
Comment 1 Ming Hua 2020-11-18 11:29:07 UTC
The ICU updated was done in commit 8335c8c20765d4f167d9b48e6a2757864a3bc7fd:
https://git.libreoffice.org/core/+/8335c8c20765d4f167d9b48e6a2757864a3bc7fd

Looking at its changes to external/icu/ExternalPackage_icu.mk no explicit version number is specified, so everything should work as ICU_MAJOR is changed from 67 to 68.  And there is definitely nothing in external/icu/ExternalPackage_icu.mk that should generate:

> libreoffice/external/icu/ExternalPackage_icu.mk:37: *** file workdir/UnpackedTarball/icu/source/lib/libicudata.so.67.1 does not exist in the tarball.  Stop.
> make: *** [Makefile:282: build] Error 2

Are you sure you built from a fresh checked-out source?  Or if not, did you try "make clean" first?
Comment 2 arungiridhar 2020-11-18 15:53:29 UTC
Solved it -- "make clean" didn't work (gave the same error again), but deleting the build directory completely and running autogen.sh before rebuilding it did work. Current version that builds properly: 179812eff88b85f34cb85eaa9b9ad027cb6a979c. 

This bug report can be closed.
Comment 3 Ming Hua 2020-11-18 16:11:17 UTC
(In reply to arungiridhar from comment #2)
> Solved it -- "make clean" didn't work (gave the same error again), but
> deleting the build directory completely and running autogen.sh before
> rebuilding it did work. Current version that builds properly:
> 179812eff88b85f34cb85eaa9b9ad027cb6a979c.
Good to know.  In principle "make clean" should work or the build process should give better error message (like suggesting re-running autogen.sh or something), or documentation should be more clear about what to do when external tarballs are updated.

However, I know too little about the build system to be of any help.  The reporter, or anyone experiencing similar problem please feel free to investigate more and make suggestions.

> This bug report can be closed.
Closing as WORKSFORME as requested.  Anyone who wants to investigate and improve can reopen.