Bug 138322 - [writer] wrong button given on tip of the day 153/222
Summary: [writer] wrong button given on tip of the day 153/222
Status: RESOLVED MOVED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
7.0.1.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Tip-Of-The-Day
  Show dependency treegraph
 
Reported: 2020-11-19 06:30 UTC by Daniel Frost
Modified: 2020-11-20 02:38 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Screenshot of German version (20.84 KB, image/png)
2020-11-19 06:31 UTC, Daniel Frost
Details
Screenshot of English version (20.75 KB, image/png)
2020-11-19 06:31 UTC, Daniel Frost
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Frost 2020-11-19 06:30:18 UTC
Description:
The tip of the day 153/222 describes how to apply headline formats by key combinations. For level one STRG + 1 is given (fine). 

But level two specifies as different combination:
GERMAN: ALT + 2. 
ENGLISH UK: %MOD11 + 2

See screenshots.

Note: I am not sure if this

Steps to Reproduce:
1. Read tip of the day no. 153/222


Actual Results:
A wrong key combination is given for the second level.

Expected Results:
The correct combination with STRG is shown.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.1.2 (x86)
Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
CPU threads: 6; OS: Windows 10.0 Build 17763; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

Using LO portable.
Comment 1 Daniel Frost 2020-11-19 06:31:08 UTC
Created attachment 167392 [details]
Screenshot of German version
Comment 2 Daniel Frost 2020-11-19 06:31:35 UTC
Created attachment 167393 [details]
Screenshot of English version
Comment 3 Ming Hua 2020-11-19 16:26:31 UTC
The German UI problem is a bug in German translation.  The string is here:
https://weblate.documentfoundation.org/translate/libo_ui-master/cuimessages/de/?checksum=3161aa3566917a60
I don't have Weblate rights to change the German translation, but I've made a suggestion, and the German translators should review and accept it soon.

As for the strange %MOD1 thing you saw on the en-GB UI, that is actually a separate bug, but not really related.  That bug has been reported and fixed in version 7.0.2, see bug 135790.
Comment 4 Heiko Tietze 2020-11-19 16:39:52 UTC
(In reply to Ming Hua from comment #3)
> The German UI problem is a bug in German translation. 

Correct, and Hua suggested the solution on Weblate (nothing more to do). Resolving as MOVED.

> That bug has been reported and fixed in version 7.0.2, see bug 135790.

That's right, too. Would be nice to double-check if the patch needs to be backported.
Comment 5 Ming Hua 2020-11-19 16:59:03 UTC
(In reply to Heiko Tietze from comment #4)
> Resolving as MOVED.
Alright.  Never sure about how to handle translation bugs on Bugzilla.

> (In reply to Ming Hua from comment #3)
> > That bug has been reported and fixed in version 7.0.2, see bug 135790.
> 
> That's right, too. Would be nice to double-check if the patch needs to be
> backported.
Backport to where?  According to bug 135790 the patch was applied to master then backported to 7-0 branch, so both 7.1.x and 7.0.x series are covered.  I don't think 6.4 or earlier versions use this %MOD1/%MOD2 string substitution thing (but you are the author of these changes, so I probably missed something).
Comment 6 Heiko Tietze 2020-11-19 18:13:01 UTC
(In reply to Ming Hua from comment #5)
> Backport to where?  According to bug 135790 the patch was applied to master
> then backported to 7-0 branch...

Haven't checked myself where the patch has landed but...

(In reply to Daniel Frost from comment #0)
> Version: 7.0.1.2 (x86)

...is strange then.
Comment 7 Ming Hua 2020-11-20 02:38:12 UTC
(In reply to Heiko Tietze from comment #6)
> (In reply to Ming Hua from comment #5)
> > Backport to where?  According to bug 135790 the patch was applied to master
> > then backported to 7-0 branch...
> 
> Haven't checked myself where the patch has landed but...
> 
> (In reply to Daniel Frost from comment #0)
> > Version: 7.0.1.2 (x86)
> 
> ...is strange then.
The patch landed between 7.0.1 and 7.0.2, so it's expected that reporter's 7.0.1 version still has the problem.  Nothing to worry about.