The recently added Math feature [1] included a few new color names in the UI, among which "fuchsia". As far as I understand, in HTML/CSS colors fuchsia is synonym to magenta, and these two names refer to the same color. According to Weblate search, before this change, the name "fuchsia" is not used in LO UI except as an alternative synonym for LibreLogo command. Everywhere else uses "magenta". So for consistency's sake, and to avoid confusion/headache of translators, can Math change the UI name for the color to "magenta" as well? 1. https://git.libreoffice.org/core/+/0643dab6819bdf248321d27f6b58a2cce125e51c
(In reply to Ming Hua from comment #0) > The recently added Math feature [1] included a few new color names in the > UI, among which "fuchsia". Some colors where added to the UI, but actually all HTML colors are supported. > As far as I understand, in HTML/CSS colors fuchsia is synonym to magenta, > and these two names refer to the same color. According to Weblate search, > before this change, the name "fuchsia" is not used in LO UI except as an > alternative synonym for LibreLogo command. Everywhere else uses "magenta". https://developer.mozilla.org/en-US/docs/Web/CSS/color_value Fuchsia and aqua where originally implemented on CSS1, but in CSS3 synonyms magenta and cyan where added. All the keywords still working. > So for consistency's sake, and to avoid confusion/headache of translators, > can Math change the UI name for the color to "magenta" as well? > > 1. > https://git.libreoffice.org/core/+/0643dab6819bdf248321d27f6b58a2cce125e51c I changed it to match mathml standars: https://www.w3.org/TR/MathML3/chapter2.html#fund.color Color values can also be specified as an html-color-name, one of the color-name keywords defined in [HTML4] ("aqua", "black", "blue", "fuchsia", "gray", "green", "lime", "maroon", "navy", "olive", "purple", "red", "silver", "teal", "white", and "yellow"). Note that the color name keywords are not case-sensitive, unlike most keywords in MathML attribute values, for compatibility with CSS and HTML. I have some work to do around starmath color this weekend because of something I screw up. If you still think it has to be reverted mark the bug as new and will apply.
(In reply to dante19031999 from comment #1) > (In reply to Ming Hua from comment #0) > > The recently added Math feature [1] included a few new color names in the > > UI, among which "fuchsia". > > Some colors where added to the UI, but actually all HTML colors are > supported. I see. Also looking at the commit I referred to in comment 0 more closely, that's actually not the commit which introduced the cyan/magenta => aqua/fuchsia change, an earlier commit did that. The commit I referred to actually added quite a few more color names from "coral" to "snow" to UI, but those strings are not in Weblate yet. > > So for consistency's sake, and to avoid confusion/headache of translators, > > can Math change the UI name for the color to "magenta" as well? > > I changed it to match mathml standars: > > [...] > > I have some work to do around starmath color this weekend because of > something I screw up. If you still think it has to be reverted mark the bug > as new and will apply. With these new color names added, I'm not so sure anymore. Being consistent with standard is also good. And with more HTML/CSS color name added, the translators need to find proper terms for them anyway (LO actually have an HTML pallette right now, but the color names in it are not localized, so they are shown as English in all UIs). I don't use Math much myself, and this bug is just from a translator's point of view. I wouldn't want my personal opinion to have too much weight, and would rather leave you the developer to decide. If you want more opinions, we can always ask the UX (user experience) team.
> I see. Also looking at the commit I referred to in comment 0 more closely, > that's actually not the commit which introduced the cyan/magenta => > aqua/fuchsia change, an earlier commit did that. The commit I referred to > actually added quite a few more color names from "coral" to "snow" to UI, > but those strings are not in Weblate yet. > With these new color names added, I'm not so sure anymore. Being consistent > with standard is also good. And with more HTML/CSS color name added, the > translators need to find proper terms for them anyway (LO actually have an > HTML pallette right now, but the color names in it are not localized, so > they are shown as English in all UIs). > I don't use Math much myself, and this bug is just from a translator's point > of view. I wouldn't want my personal opinion to have too much weight, and > would rather leave you the developer to decide. If you want more opinions, > we can always ask the UX (user experience) team. Making any change takes me five minutes. So there's no problem to do it one way or another. Applied some standards to the UI. But users, translators and others are not computers, and I'm not good with other humans. So I'm not the suited person to do the decision. Now that you have all the info you can take the decision, or if you're not sure ask the UX team.
(In reply to dante19031999 from comment #3) > or if you're not sure ask the UX team. Sure, let's do that. A summary for the UX team: 1. Math supports a set of HTML/CSS colors as commands, among which the two "aqua/cyan" and "fuchsia/magenta" pairs. The two names in each pair are synonyms and corresponds to the same color. 2. All color names can be used in commands, but only some are shown in UI (and thus need translations). In 7.0 and earlier, only "cyan" and "magenta" are shown in UI. 3. A recent change in master changed these two UI strings to "aqua" and "fuchsia", to be consistent with MathML standard. "Cyan" and "magenta" are no longer shown. However, these two words are not previously used in LibreOffice UI, except one instance in LibreLogo commands, where "aqua/cyan" and "fuchsia/magenta" are listed together as synonyms (and maybe another instance in the HTML pallette, but the strings there are not localized). Should the Math UI keep the change to adhere to MathML standards, or revert back to reduce confusion for users and translators?
In a MathML context the "named colors" are technically keywords, used for filter import, in the markup, and for exported MathML--so really not subject to localization. Color values drawn from HTML4 era color names/values as listed using "aqua" and "fuchsia". IIRC the "cyan" and "magenta" were held over from old StarMath 5 color keywords, but those colors are rendered to the "aqua" and "fuchsia" HTML4 values of MathML standard (our LIGHTCYAN and LIGHTMAGENTA definitions). The GUI exposed color name keywords should follow the MathML standard, and if we still need the CYAN & MAGENTA for backward StarMath compatibility--they can stay, just not on the Elements -> Attributes panel. When Regina implemented the 16 HTML4 colors she'd kept CYAN & MAGENTA around--see bug 40436, and for AOO i118191, but we should have quashed the cyan & magenta entries on the Elements panel and moved to aqua & fuchsia then. Other than these exact keyword<==>RRGGBB pairings, no other "named colors" make sense--and potentially cause interoperability issues for our sm formulas (OLE or as exported). Meaning now with Dante's excellent work to expand the use of colors in the sm Formula editor, a viable color picker is needed to specify the colors as MathML #RRGGBB values. The SVX picker, opening any SOC palette for use, would support color name localization in its labels. The subject of see also bug 138129
@Dante, FIXED or WONTFIX? I don't see a commit in gerrit that touches this...
(In reply to V Stuart Foote from comment #6) > @Dante, FIXED or WONTFIX? I don't see a commit in gerrit that touches > this... My english is not the best, but understood that in the UI magenta has to be replaced with fuchsia and cyan with aqua. Is is already done: https://gerrit.libreoffice.org/c/core/+/105526 Check dockingelementswindow.
(In reply to V Stuart Foote from comment #6) > @Dante, FIXED or WONTFIX? I don't see a commit in gerrit that touches > this... Or do I have to revert the naming change?
(In reply to dante19031999 from comment #8) > (In reply to V Stuart Foote from comment #6) > > @Dante, FIXED or WONTFIX? I don't see a commit in gerrit that touches > > this... > > Or do I have to revert the naming change? No. Stuart's opinion is that the current "aqua/fuchsia" name that matching MathML stadard is good, and no need to change. Assuming that's UX team's opinion (since no one else objected), the current code is good. It's just that this bug is asking you to change "aqua/fuchsia" back to "cyan/magenta", and resolving the bug as FIXED is confusing and technically wrong. Acutally even WONTFIX sounds wrong to me, let's make it NOTABUG since the current "aqua/fuchsia" is the intended behavior.
OK, the current GUI change to aqua/fuchsia from cyan/magenta matches the MathML keywords. The revert would have been to restore cyan/magenta which would then be wrong to standard (but which we'd carried in the GUI for some time). => WF to doing the revert. But, likely have a documentation issue for the help and userguide(s).
(In reply to V Stuart Foote from comment #10) > But, likely have a documentation issue for the help and userguide(s). Indeed, I filed bug 138418 for documentation.