Bug 138363 - add setting to read icons.css for collibre svg icons
Summary: add setting to read icons.css for collibre svg icons
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Icon-Themes-Code
  Show dependency treegraph
 
Reported: 2020-11-20 08:47 UTC by andreas_k
Modified: 2020-11-20 11:58 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2020-11-20 08:47:25 UTC
I prepare to make the colibre-svg icons themable with .css

In the *.svg files there will be the default colibre styles but a class object where you can overwrite the settings from each single .svg file with the settings from icons.css.

I already work on the svg icon update and on the icons.css file, however in the end my question is, should we add somewhere an option to load specific .css files for the icons? Would be nice to load icons.css from the extension webpage.

One main benefit would be that it's way easier to start make a new icon theme cause you can change the icons.css file and than redraw icons you would like to change (no complete new icon theme needed).
Comment 1 Mike Kaganski 2020-11-20 10:13:30 UTC
Please close it WONTFIX.

Assigning a random CSS to a set of SVGs in a random theme, without any clear API for what CSSS classes are expected in the file (so all themes must follow the same rules??), or how to handle versioning (how to deal with a CSS created for older SVGs, which didn't require CSS class X), would introduce many problems to users. Making something like "CSS as extension" would have all the same problems. That will bring multiple problems for users when things don't work as intended, for *no* practical benefit.

It's OK to have the CSS near the SVGs, in the way that the CSS is part of the icon set. So it's the icon set's author's responsibility to prepare it consistent, and everything is in order; there's no unnecessary complications with "standardization" of the CSS subtype that our themes might use, etc.

And it's OK (for user) to just have 5 identical themes with all SVGs being bit-to-bit identical, but which have different SVGs. The user would just have several variants of icon sets; the disk footprint is negligible; and no UI is required. The identical SVGs are just an implementation detail. No need to make the UI more complex; no need to change *anything* at all. Just make your SVG icon set include and use the CSS properly (as an author/contributor), and upload the end result.
Comment 2 Mike Kaganski 2020-11-20 10:37:26 UTC
(In reply to Mike Kaganski from comment #1)
> And it's OK (for user) to just have 5 identical themes with all SVGs being
> bit-to-bit identical, but which have different SVGs.

Sorry, a thinko: it should end with "but which have different CSS" instead of "different SVGs".
Comment 3 andreas_k 2020-11-20 11:58:09 UTC
Thanks for the feedback here and at the design channel.