Bug 138533 - Use GtkSpinButton for .uno:FontHeight
Summary: Use GtkSpinButton for .uno:FontHeight
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2020-11-27 21:36 UTC by andreas_k
Modified: 2020-12-10 07:59 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
GtkSpinButton for .uno:FontHeight (34.17 KB, image/png)
2020-11-27 21:36 UTC, andreas_k
Details
Screenshot with Chinese UI (13.79 KB, image/png)
2020-12-02 23:54 UTC, Ming Hua
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2020-11-27 21:36:35 UTC
Created attachment 167625 [details]
GtkSpinButton for .uno:FontHeight

The GtkSpinButton has the benefit compare to the drop-down widget for FontHeight, that .uno:Shrink and .uno:Grow are not needed, cause there are already +/- buttons within the GtkSpinButton.

Google Docs has also some kind of a SpinButton.
Comment 1 andreas_k 2020-11-27 21:38:38 UTC
Not only in the Sidebar you can reduce remove .uno:Grow and .uno:Shrink commands when there is a SpinButton for .uno:FontHeight.
- Toolbar
- Notebookbar
- Sidebar
Comment 2 Heiko Tietze 2020-12-02 16:26:39 UTC
A spin box accepts a range of values with minimum and maximum, allows to enter values, and to in-/decrease per click. So far it fits into the concept. But we lose the ability to switch from 12 to 36, for example.
Comment 3 andreas_k 2020-12-02 23:19:28 UTC
(In reply to Heiko Tietze from comment #2)
> But we lose the ability to switch from 12 to 36, for example.

You can write a number into a spin box isn't it?

You reduce two icons in the sidebar, notebookbar and also in the toolbar you can remove two icons. So less visual clutter, but with no reduced functionality and I thing better behavior (also on touch screens).
Comment 4 Ming Hua 2020-12-02 23:54:50 UTC
Created attachment 167777 [details]
Screenshot with Chinese UI

I know nothing about UI design, but I'd like to mention that in simplified Chinese typesetting and publishing at least (most likely also traditional Chinese, maybe Japanese as well), the font size is not described in point (pt) numbers.  The Chinese rather use its own system, which LO adopts, and provides a rough conversion to and from the point system.

In this Chinese system the sizes are just called "Size <n>", with n ranging from 0 to 8, and with "Size <n> Minus" in between numbers.  The default font size in Writer for Chinese UI is "Size Five", which translates to 10.5 pt for English UI.  I've attached a screenshot of how .uno.FontHeight dropdown list looks in Chinese UI.

I hope the developers can have this in mind when they change the UI, or provide a fallback to the old dropdown list that Chinese users can use.  Thanks.
Comment 5 Adolfo Jayme Barrientos 2020-12-03 04:38:00 UTC
I know Google Docs has made this widget fashionable, but it’s too big in GTK and both sidebar and toolbars are already space-constrained, so my recommendation is a WONTFIX.
Comment 6 Roman Kuznetsov 2020-12-03 06:02:20 UTC
(In reply to Adolfo Jayme from comment #5)
> I know Google Docs has made this widget fashionable, but it’s too big in GTK
> and both sidebar and toolbars are already space-constrained, so my
> recommendation is a WONTFIX.

Fully agree with Adolfo, don't need do it.
Comment 7 Heiko Tietze 2020-12-10 07:59:45 UTC
We discussed the idea in the design meeting. While it looks nice and clean the counter-argument are strong. Besides the CJK special handling we would have to align the input with the toolbars and spin edits there are rather aliens.