Bug 138590 - PARAGRAPH STYLES: Not editing the style selected from dropdown, editing the one selected in text instead
Summary: PARAGRAPH STYLES: Not editing the style selected from dropdown, editing the o...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.3.1 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0 target:7.0.5 target:7.1.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Styles-Paragraph-Combobox
  Show dependency treegraph
 
Reported: 2020-12-01 04:27 UTC by tomaskeb
Modified: 2021-02-10 08:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tomaskeb 2020-12-01 04:27:13 UTC
Description:
The other fields say it clearly.

Steps to Reproduce:
Say I have e.g. "heading 1" and "body text" style in my document. I want to edit the "body text" style from the dropdown, but the text cursor is on the "heading 1" style.

Actual Results:
When I have my cursor placed on the "heading 1" and choose to edit "body text" from the dropdown, the opened dialog belong to the "heading 1" style. (Basically, any style with currently placed cursor is edited, not the one you want.)

Expected Results:
I can edit any style regardless what is selected in text or where the cursor is.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: cs-CZ (cs_CZ); UI: cs-CZ
Calc: threaded
Comment 1 tomaskeb 2020-12-01 04:28:49 UTC
Of course you have to have some text with the respective styles applied on them.
Comment 2 Dieter 2020-12-16 07:29:29 UTC
I confirm it with

Version: 7.1.0.0.beta1 (x64)
Build ID: 828a45a14a0b954e0e539f5a9a10ca31c81d8f53
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

and with

Version: 7.0.4.2 (x64)
Build ID: dcf040e67528d9187c66b2379df5ea4407429775
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

You can select "Edit Style" for each paragraph style in the dropdown list, but always the dialog for the current style is opened. Sidebar works fine.


Works fine in

Version: 6.3.6.2 (x64)
Build-ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: CL
Comment 3 Justin L 2021-01-26 18:13:06 UTC
Introduced in LO 7.0 by author Caolán McNamara on 2020-04-24 17:48:00 with 
commit 16309a9516c1f173056fc103c6428e74217c7927 
    weld StylesPropertyPanel
Comment 4 Caolán McNamara 2021-01-26 20:38:22 UTC
pulling the wrong stylename from the box rather than the highlighted menu entry
Comment 5 Commit Notification 2021-01-27 12:38:17 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d759009fd85c4e17dc7d482a84e22510e7949f16

tdf#138590 use the highlighted menu entry, not the combobox active text

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2021-01-27 14:08:11 UTC
done in master, backport to 7-1 and 7-0 in gerrit
Comment 7 Commit Notification 2021-01-27 17:08:28 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/0211b72c3d8bc7cf51b54dc4e4a0cf346153da46

tdf#138590 use the highlighted menu entry, not the combobox active text

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-01-27 17:08:40 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/17d27a27bc12b24ef48aef4722ab104b16eb50d2

tdf#138590 use the highlighted menu entry, not the combobox active text

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Dieter 2021-02-10 08:17:30 UTC
VERIFIED with

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 396c2ad2daad6fe6a11703d0ae1593929834afe2
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

Caolán, thanks for fixing it!