Bug 138615 - Insure Windows wildcards work properly with long paths
Summary: Insure Windows wildcards work properly with long paths
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All Windows (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Commandline
  Show dependency treegraph
 
Reported: 2020-12-02 06:43 UTC by Deb
Modified: 2022-12-07 03:22 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Deb 2020-12-02 06:43:48 UTC
Description:
In Windows, we must manually handle wildcards like ? and *. We use FindFirstFileW() in loader.cxx to handle the wildcards. FindFirstFileW() may not handle paths over 255 characters unless a \\?\ is prepended. If given an absolute path prepend a \\?\.

Steps to Reproduce:
1.soffice.exe c:\veryLongPath\*.docx
2.
3.

Actual Results:
Long path names do not have their wildcards expanded.

Expected Results:
Long path names have their wildcards expanded.


Reproducible: Always


User Profile Reset: No



Additional Info:
Taken from Mike's comments on https://gerrit.libreoffice.org/c/core/+/106393
Comment 1 Mike Kaganski 2020-12-02 07:03:31 UTC
I would suggest using PathCchCanonicalizeEx for this, with PATHCCH_ENSURE_IS_EXTENDED_LENGTH_PATH flag. It fits perfectly for the task, except conversion of "/" into "\" - it does everything else, like removing "." and "..", making sure the path has the "\\?\" in case when the mask is shorter than 2MAX_PATH, but the found name would be longer ... but the problem is, the function is supported since Windows 8, while our baseline is Windows 7 still.

[1] https://docs.microsoft.com/en-us/windows/win32/api/pathcch/nf-pathcch-pathcchcanonicalizeex
Comment 2 Mike Kaganski 2020-12-02 10:16:28 UTC
(In reply to Mike Kaganski from comment #1)
> but the
> problem is, the function is supported since Windows 8, while our baseline is
> Windows 7 still.

On the other hand, https://stackoverflow.com/questions/57354840/which-dll-has-pathcchappend suggests that the function may be in api-ms-win-core-path-l1-1-0.dll, which is part of UCRT, which we depend on, and which we require on Windows 7. The function is not guarded by any "#if _WIN32_WINNT >= 0x0602" thing in pathcch.h - so maybe it's actually works on Win7 SP1 with UCRT? Could you check?
Comment 3 QA Administrators 2022-12-07 03:22:28 UTC
Dear Deb,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug