Bug 138666 - "Display tracked deletions in margin" option does not take into effect immediately
Summary: "Display tracked deletions in margin" option does not take into effect immedi...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.beta1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: tracked-changes-in-margin
  Show dependency treegraph
 
Reported: 2020-12-05 03:14 UTC by Ming Hua
Modified: 2021-02-02 13:24 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Hua 2020-12-05 03:14:26 UTC
Description:
The new "display tracked deletions in margin" option doesn't have (full) effect on how text is displayed immediately after changing the option in Tools > Options dialog, only after a save the effects are shown.

Steps to reproduce:
1. Clean user profile, new writer document, type or paste some random text;
2. Turn on change tracking with menu "Edit > Track Changes > Record";
3. Delete some part of the text, they are shown in place colored and with strikethrough;
4. Tools > Options > LO Writer > View dialog, check "Tracked deletions in margin", press OK button;
5. The deleted text now are both shown in margin, *and* shown in place colored and with strikethrough;
6. Save the document, now the deleted text is only shown in margin.

Expected behavior:
In step 5 above, the deleted text should be only shown in margin.

Similar bug exists if the deletion was done when "Tracked deletions in margin" was checked, then the option is unchecked in the dialog.  The deleted text would disappear from margin and *not shown in place* until the document is saved.

This is 7.1.0 Beta1 on Windows 10:
Version: 7.1.0.0.beta1 (x64)
Build ID: 828a45a14a0b954e0e539f5a9a10ca31c81d8f53
CPU threads: 2; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: en-US
Calc: threaded
Comment 1 NISZ LibreOffice Team 2020-12-07 11:40:17 UTC
Confirming in:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 561e5559bb68242c7f785f0ca3bee3eb12b58963
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL
Comment 2 Commit Notification 2021-01-20 10:55:33 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/644f9abce55878e27292451b9b2c8d3b6e11104e

tdf#138666 sw: fix enable/disable of ChangesInMargin mode

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 NISZ LibreOffice Team 2021-02-02 13:24:06 UTC
Verified in: 
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 01ac21d99fb9945f9d3ab2fe3ed04e3c86fa5583
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-GB
Calc: threaded

Thanks for fixing!