Bug 138684 - Pasting SVG bitmap/GDI paste quality worsened (even more) since 7.0/7.1 (affecting also DOCX export)
Summary: Pasting SVG bitmap/GDI paste quality worsened (even more) since 7.0/7.1 (affe...
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: Not Assigned
Whiteboard: target:7.2.0 target:7.1.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Images Paste-Special
  Show dependency treegraph
Reported: 2020-12-05 19:52 UTC by Telesto
Modified: 2023-11-05 16:25 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Example file (39.48 KB, application/vnd.oasis.opendocument.text)
2020-12-05 19:52 UTC, Telesto

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-05 19:52:35 UTC
Pasting SVG bitmap paste quality worsened (even more) since 7.0/7.1

Steps to Reproduce:
1. Open the attached file
2. Cut the image
3. CTRL+SHIFT+V -> Bitmap or GDI paste

Actual Results:
Text in the right corner impossible to read

Expected Results:
It was readable in 6.4.. quality wise still bad.. again better with 4.0.. before transparency got added (but still not perfect).. but simply in case all of these being relevant somehow

Reproducible: Always

User Profile Reset: No

Additional Info:
Version: (x64)
Build ID: 32fdb8eb3506bc8dcf013cc713fe8e5debceb940
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-12-05 19:52:50 UTC
Created attachment 167853 [details]
Example file
Comment 2 Laura Garcia 2020-12-17 09:40:58 UTC
Thank you for reporting the bug. I can confirm that the bug is present in
Build ID: d9ccee2231a8d8984302e1b2f578bf73b4d60c35
CPU threads: 4; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

Additional comments:
Paste special bitmap quality significantly reduces between version to, the latter one pastes the image in much lower resolution, in this example the image has text and the text can’t be read anymore due to image quality distortion.
Comment 3 Aron Budea 2020-12-19 10:56:50 UTC
This deteriorated in two steps, by the following two commits. Adding CC: to Mike Kaganski.

author		Mike Kaganski <mike.kaganski@collabora.com>	2020-08-24 00:13:19 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2020-08-24 04:33:34 +0200

"tdf#136047: fix OutputDevice::DrawTransformBitmapExDirect for ..."

author		Mike Kaganski <mike.kaganski@collabora.com>	2020-08-24 07:56:46 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2020-08-24 07:49:02 +0200

"Don't apply transparency twice when drawing to mpAlphaVDev"

Both commits reference the following one as the culprit for regressions they're fixing, however this commit didn't have an impact on bitmap paste:
Comment 4 Telesto 2020-12-19 11:22:36 UTC
For the record, this a case of something broken before becoming even worse. So  the regression part is debatable at minimum :P (probably even 'wrong' in technical sense). I assume the identified commits are not the 'actual' problem.. the image handling being wrong previously.. So this identified commit an existing problem (even) more prominent.
Comment 5 Stéphane Guillou (stragu) 2023-11-05 16:25:20 UTC
Just like for bug 139085, fixed in 7.1 by 058b59ae92ca19beed698ad1a2d6ee6f1182213a, which is a cherrypick of:

commit 6b8c157a0b4f37a09fdbf656919b2df06a3abc3e
author	Luboš Luňák Thu Mar 04 15:35:44 2021 +0100
committer	Luboš Luňák Mon Mar 08 13:46:36 2021 +0100
make RenderMaskPrimitive2DPixel() clip using clipping (tdf#140797)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111966

Thanks Luboš!

("fixed" as in the quality is back to what in was in 6.4 when following the same steps.)

Unrelated to SVG import. Changing metas.