Bug 138750 - Add option to make paragraph border color same as paragraph default font color
Summary: Add option to make paragraph border color same as paragraph default font color
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.3.1 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2020-12-08 18:50 UTC by Olivier Hallot
Modified: 2020-12-11 13:45 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
How paragraph-style font color works (858.60 KB, image/gif)
2020-12-11 12:09 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2020-12-08 18:50:45 UTC
Paragraphs and (headings) border color is independent from (default) paragraph font color.

Use case:  n a situation where I want to change the color of the paragraph (default) font, I also have to set the border color,  if the border color is to follow the font color.

Today this must be done manually for all paragraph with borders.

Suggestion:
Add a checkbox in the border tab of the paragraph style to inherit the font color for the border color. For example, a green font color will be applied to the border color

When the checkbox is selected, the border color selector is disabled and the border color applied is taken from the paragraph font color for the style (set in Font Effects tab). For example, a green font color will be applied to the border color, turning border to green.

When the checkbox is cleared, the border color selector is enabled and user must select border color manually.
Comment 1 Heiko Tietze 2020-12-11 10:01:57 UTC
Sounds reasonable. What do you think, Mike?
Comment 2 Mike Kaganski 2020-12-11 10:05:54 UTC
While indeed that is possible, and I personally do not object that, there are two things to note:

1. It would likely need an ODF support. Could Regina possibly evaluate if this is possible using existing ODF features, or what would be the proper way to extent ODF here?

2. Wrt "this must be done manually for all paragraph with borders" - this is a classic example where this should be a *style*, which localizes the change to a single place.
Comment 3 Heiko Tietze 2020-12-11 10:45:32 UTC
(In reply to Mike Kaganski from comment #2)
> 1. It would likely need an ODF support.
Not necessarily if the checkbox just affects the dialog. Meaning if checked the color is changed automatically.
Comment 4 Mike Kaganski 2020-12-11 10:52:26 UTC
(In reply to Heiko Tietze from comment #3)

What do you mean?
The request is to make the color of border to *automatically* follow the color of text; so that when Olivier *later changes color of the paragraph font*, the border also changes the color. The latter task does not necessarily involve any dialog at all. It is establishing a functional link between some properties of *some* objects (I suppose that it should only be effective for the paragraphs/styles where that is set, right?); and additionally, that would most probably be expected to survive the save-and-reload roundtrip.

Of course, Olivier could elaborate to clarify the confusion. My understanding is based on this part from comment #0:
> Use case:  n a situation where I want to change the color of the paragraph
> (default) font, I also have to set the border color,  if the border color is
> to follow the font color.
> 
> Today this must be done manually for all paragraph with borders.
Comment 5 Heiko Tietze 2020-12-11 11:03:37 UTC
(In reply to Mike Kaganski from comment #4)
> The request is to make the color of border to *automatically* follow the
> color of text...

I wouldn't enhance the format. Rather if the user changes the color in the dialog it is also applied at the other places. This has its limitation, of course, but would be easy to implement. And the checkbox is perhaps better located at font color as "[ ] Apply to border color" (disabled if no border is set).
Comment 6 S.Zosgornik 2020-12-11 11:52:12 UTC Comment hidden (off-topic)
Comment 7 Mike Kaganski 2020-12-11 12:09:03 UTC Comment hidden (off-topic)
Comment 8 S.Zosgornik 2020-12-11 12:13:30 UTC Comment hidden (off-topic)
Comment 9 Mike Kaganski 2020-12-11 12:14:33 UTC Comment hidden (off-topic)
Comment 10 S.Zosgornik 2020-12-11 12:15:47 UTC Comment hidden (off-topic)
Comment 11 S.Zosgornik 2020-12-11 12:24:15 UTC
Instead of having a checkbox would I rather suggest to have the default paragraph font color (as already chosen) as the per-selected border AND shadow color of the related paragraph so users only have to select the border/shadow style.
Comment 12 Mike Kaganski 2020-12-11 12:28:48 UTC
People, please try to comprehend the request. Comment 0 tells, that Olivier wants the paragraphs that *already have borders*, to change the color of those borders when he changes the font color. It is not about creation of a border in a paragraph without a border.

The "this must be done manually for all paragraph with borders" clearly implies that. Please don't change the topic randomly! Thanks.
Comment 13 S.Zosgornik 2020-12-11 12:49:28 UTC
(In reply to Mike Kaganski from comment #12)
> People, please try to comprehend the request. Comment 0 tells, that Olivier
> wants the paragraphs that *already have borders*, to change the color of
> those borders when he changes the font color. It is not about creation of a
> border in a paragraph without a border.
> 

How many persons did you just spoke to by saying "People"?

I was supposing that the default color of a paragraph border or shadow should be the default font color of the same paragraph. That would mean to set the paragraph font color first and set the paragraph border/shadow later.
Have an checkbox that always set the border color to the font color seems rather contra-productive to me: How would you name this check box?
"Set border color always to default paragraph color."
This would never fits inside the current color-dialog. Also this would clutter the UI for a very limited use-cases.
In my opinion a WF!
Comment 14 Mike Kaganski 2020-12-11 12:56:44 UTC
(In reply to Sascha Z from comment #13)
> How many persons did you just spoke to by saying "People"?

Two: you and Heiko (from comment 3) :-)
Comment 15 Mike Kaganski 2020-12-11 13:03:55 UTC
(In reply to Sascha Z from comment #13)
> In my opinion a WF!

I agree. Here is why:

1. As I wrote in comment 2, if you use paragraph styles properly, the task is very limited. It isn't worth the increased complexity.

2. The font color is a *character* property (even if set on paragraph level). The *paragraph* border is a paragraph-level property; and also we have a border on character level. Making a paragraph property dependent on character property is very awkward on model level; and why then limit to paragraph border? character border feels as "natural"; and also tables, frames, pages ... etc. all have borders - would it be inconsistent to only add such a setting for paragraph borders? and then - what convoluted and unexpected interconnections would we introduce?
Comment 16 Olivier Hallot 2020-12-11 13:39:04 UTC
The idea came by common, terrian usage (see recent Guides published in documentation.libreoffice.org). In that case, heading1 has a bottom border that should follow font color.

Style inheritance can solve this and is best practice on styling:
1) customize Title style 
2) make all heading properly inherit properties (which includes font and border settings) from Title.

Real case is that most of the time, documents are a mess of styles, the checkbox suggested is a small convenience to the paragraph style used in Heading to follow font color for borders.
Comment 17 Heiko Tietze 2020-12-11 13:45:00 UTC
(In reply to Mike Kaganski from comment #15)
> (In reply to Sascha Z from comment #13)
> > In my opinion a WF!
> I agree.
Me too. All proposed solutions have pitfalls and introduce new usability shortcomings.