Bug 138790 - Line Color in sidebar isn't disabled for chart area when line is set to none
Summary: Line Color in sidebar isn't disabled for chart area when line is set to none
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Chart Sidebar-Properties-Line
  Show dependency treegraph
 
Reported: 2020-12-10 00:36 UTC by Aron Budea
Modified: 2022-02-21 19:54 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2020-12-10 00:36:55 UTC
- Start an empty Writer document, make sure the sidebar is open, and insert a chart,
- Click in the document, away from the chart twice (for some reason we can't get into chart edit mode right away),
- Double-click in the chart, somewhere in the white area outside the actual chart to get into chart edit mode,
+ in older versions (eg. 7.0) you had to click once more in the same white area to select the "Chart Area", in 
- Check Line properties in the sidebar.

=> Line is set to none by default (as expected), but Width and Color aren't disabled as they should be. They should only be enabled if there is a line set.
This bug report is about the Color.

Screenshot in 7.2: attachment 168020 [details]
Screenshot in 6.4: attachment 168021 [details]

Observed in LO 7.2.0.0.alpha0+ (b541cd9a8038810ce449f8c49ae179d9d6eaa7e8), 7.0.0.3 / Ubuntu.
No issue in 6.4.0.3. => regression

Bibisected to the following commit using repo bibisect-linux-64-7.0. Adding CC: to Dennis Francis.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5f193d851e3567e1018a61763846698e02ce38ec
author		Dennis Francis <dennis.francis@collabora.com>	2020-02-23 22:38:15 +0530
committer	Andras Timar <andras.timar@collabora.com>	2020-02-28 22:54:43 +0100

chart2: Fix the color uno command in ChartColorWrapper
Comment 1 Aron Budea 2020-12-10 00:54:49 UTC
In addition, the disabled Color control should show as empty, and not be black.
Comment 2 Justin L 2022-02-09 08:49:24 UTC
Tested in 7.4. Color is disabled.  (I assume fixed by bug 138789 in 7.0.5.)

I don't see a "none" or "empty" option for color.  The disabled color shown is the last used color. That seems reasonable to me.

I suggest this bug be closed.
Comment 3 Aron Budea 2022-02-21 19:54:28 UTC
Indeed, I can confirm it's fine now in LO 7.4.0.0.alpha0+ (8942956e05f2208ffb666a2118f5db092c30ce6a) / Ubuntu.
Let's close as WFM, thanks for checking, Justin!