Bug 138870 - Track Changes toolbar reappears after Save
Summary: Track Changes toolbar reappears after Save
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.beta1+
Hardware: x86-64 (AMD64) Windows (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0 target:7.1.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2020-12-12 20:50 UTC by dev
Modified: 2021-03-28 11:24 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dev 2020-12-12 20:50:21 UTC
Description:
A previously-hidden toolbar (Track Changes) reappears after Save, or after clicking outside then inside the main text frame.

Steps to Reproduce:
Variant A:
1. Hide the Track Changes toolbar, using the Show Tracked Changes icon in the main toolbar.
2. Save (Ctrl+S).

Variant B:
1. Hide the Track Changes toolbar, using the Show Tracked Changes icon in the main toolbar.
2. Click outside the main text frame, e.g. in the grey app background.
3. Click back into the main text frame, as if to edit text.

Actual Results:
The Track Changes toolbar reappears, despite having been hidden. The main toolbar's Track Changes icon may then show the wrong active/inactive state.

Expected Results:
The Track Changes toolbar remains hidden, even if previously-tracked changes are present in the document.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Perhaps related to #135009.
Comment 1 dev 2020-12-12 20:54:19 UTC
Additional prerequisite in Steps to Reproduce:
- Tracked changes must be present in the document.
Comment 2 Dieter 2020-12-27 12:18:27 UTC
I confirm it with

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 315c7570c4a72f4c834086082825533b1e50d1bf
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

At least the fact, that in Variant B the main toolbar's Track Changes shows the wrong active/inactive status is a bug.
Comment 3 NISZ LibreOffice Team 2020-12-30 12:39:42 UTC
This is a side effect from:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=afbbfb3b55beb937555a972d9edbb47ede91001a

author	László Németh <nemeth@numbertext.org>	2020-11-10 12:22:11 +0100
committer	László Németh <nemeth@numbertext.org>	2020-11-10 14:58:29 +0100

tdf#83958: sw: enable Track Changes toolbar automatically

Adding CC to: László Németh
Comment 4 morfuinvorn 2021-01-31 09:52:32 UTC
I confirm this bug. Win 7 x64, 7.1.0RC2 and 7.1.0RC3.
Version: 7.1.0.3 (x64) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL
Comment 5 Commit Notification 2021-02-02 09:59:24 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/28d65bb877c193b3fa53a038f3b896e4ba2f7ee4

tdf#138870 sw: fix Track Changes toolbar reappearing

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-02-03 17:11:16 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/1989201c56c03b1ef13a282cfd09af69620040ea

tdf#138870 sw: fix Track Changes toolbar reappearing

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 KeepTools 2021-03-14 11:02:46 UTC
Since LibreOffice v7.1.1.2 (xubuntu 20.10) the Track Changes toolbar opens automatically when I open a .odt-file with tracked changes.

Steps to reproduce:
1. Hide the Track Changes toolbar.
2. Open an .odt-file with tracked changes.

Actual result:
The Track Changes toolbar appears.

Expected result:
The Track Changes toolbar remains hidden.

Is this behaviour the result of this fix, or should I report it elsewhere?
Comment 8 Dieter 2021-03-28 09:46:42 UTC
VERIFIED with

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: f96004096268f5e71120678e32fc8c74055819aa
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

László, thanks for fixing it!
Comment 9 Dieter 2021-03-28 09:48:05 UTC
(In reply to KeepTools from comment #7)
> Is this behaviour the result of this fix, or should I report it elsewhere?

Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/current.html ? You can install it alongside the standard version.  Please open a new report if your problem ist still present in the master build.
Comment 10 morfuinvorn 2021-03-28 10:35:53 UTC
(In reply to Dieter from comment #9)
> (In reply to KeepTools from comment #7)
> > Is this behaviour the result of this fix, or should I report it elsewhere?
> 
> Could you please try to reproduce it with a master build from
> http://dev-builds.libreoffice.org/daily/master/current.html ? You can
> install it alongside the standard version.  Please open a new report if your
> problem ist still present in the master build.

I tried this build and unfortunately it doesn't fix the situation. In documents with change tracking, the panel still appears the next time you open it, even if you manually disable it. 

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 35a06c67701eacb85591b61c948233a4f0ad238b
CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL
Comment 11 Dieter 2021-03-28 10:58:27 UTC
(In reply to morfuinvorn from comment #10)
> I tried this build and unfortunately it doesn't fix the situation. In
> documents with change tracking, the panel still appears the next time you
> open it, even if you manually disable it.

So please open a new report. You can refer to this report in "See Also" field.