Bug 138879 - Last paragraph of inserted text from ODT file does not retain paragraph style.
Summary: Last paragraph of inserted text from ODT file does not retain paragraph style.
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
7.0.3.1 release
Hardware: All All
: medium normal
Assignee: Georgy Litvinov
URL:
Whiteboard: target:7.2.0 target:7.1.0.2
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-13 14:59 UTC by Georgy Litvinov
Modified: 2021-01-04 23:17 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
file with only one paragraph (9.13 KB, application/vnd.oasis.opendocument.text)
2020-12-13 15:01 UTC, Georgy Litvinov
Details
Document to insert with 2 paragraphs (9.38 KB, application/vnd.oasis.opendocument.text)
2020-12-25 21:45 UTC, Georgy Litvinov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Litvinov 2020-12-13 14:59:34 UTC
Description:
After inserting text from ODT file last paragraph lose it's paragraph style setting. It also applies to inserting text from fodt, and ott. To comparison inserting the same text in DOCX goes correctly (last paragraph retain style settings).

Steps to Reproduce:
1. Open Writer
2. Insert - Text from file
3. Choose odt with paragraph with applied paragraph style at the end of file

Actual Results:
Last paragraph of inserted text has default paragraph style

Expected Results:
Last paragraph of inserted text should have the same applied style as is in inserted document.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.0.3.1
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 8; OS: Linux 3.10; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.utf8); UI: en-US
Calc: threaded
Comment 1 Georgy Litvinov 2020-12-13 15:01:07 UTC
Created attachment 168129 [details]
file with only one paragraph
Comment 2 Georgy Litvinov 2020-12-25 21:45:23 UTC
Created attachment 168493 [details]
Document to insert with 2 paragraphs
Comment 3 Commit Notification 2020-12-29 18:18:29 UTC
Georgy Litvinov committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/83ff5b784e910f06c9d8384ac73a1c0bda0551d5

Missing last para style when inserting text from odt file tdf#138879

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Xisco Faulí 2021-01-04 12:14:44 UTC
Verified in

Version: 7.2.0.0.alpha0+
Build ID: 2c9708cbb870483a8a1c93d722085be5f789d234
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Georgy, thanks for fixing this issue. Should it be closed as RESOLVED FIXED ?
Comment 5 Georgy Litvinov 2021-01-04 13:36:39 UTC
(In reply to Xisco Faulí from comment #4)
> Verified in
> 
> Version: 7.2.0.0.alpha0+
> Build ID: 2c9708cbb870483a8a1c93d722085be5f789d234
> CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
> Locale: en-US (en_US.UTF-8); UI: en-US
> Calc: threaded
> 
> @Georgy, thanks for fixing this issue. Should it be closed as RESOLVED FIXED
> ?

Yes. I mark this as resolved fixed.
Comment 6 Commit Notification 2021-01-04 20:53:15 UTC
Georgy Litvinov committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/abc2a0563d33726c10c6cc10c1b879d635453b61

Missing last para style when inserting text from odt file tdf#138879

It will be available in 7.1.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-01-04 23:17:38 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8e691505d4675b878b30bd00cd2e4fb4f794f0ef

tdf#138879: sw_odfimport: Add unittest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.