Created attachment 168136 [details] crash dump from LibreOfficeDev\4\crash STR come from bug 101404 1) Open draw 2) Set margins to 0 3) Save as template and enable checkbox to make it default template 4) Close doc 5) Open template manager 6) Delete draw's default template Result: Crash, with template dialog box remaining open Additional information: 1. Reproduced running in Safe Mode and reset to Factory Setting 2. Crash report does not appear to be sent, have attached .dmp file 3. Please look at bug 101404 -- because it may be possible to address some of the issues there at the same time. 4. Have not tried to test with other modules.
Tested with: Version: 7.2.0.0.alpha0+ (x64) Build ID: 368c56144aab5794c39d5bc2082d9b3d6d7cebdb CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_DK); UI: en-US Calc: threaded
Not reproducible in Version: 7.2.0.0.alpha0+ Build ID: 9a2a4bc5ed340ba187c8e27db5c8477c990c93af CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
but it does with gen Version: 7.2.0.0.alpha0+ Build ID: 9a2a4bc5ed340ba187c8e27db5c8477c990c93af CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Regression introduced by: author Vert D <devoptmsoi@gmx.com> 2020-09-25 17:58:15 -0500 committer Heiko Tietze <heiko.tietze@documentfoundation.org> 2020-11-23 11:29:04 +0100 commit 6b1de6057082bd8720594231839f967bff5372ae (patch) tree 57ae7c1982f3b270e3a42dec0bff909f6e250410 parent 3c4b09a250605c9d73e48df83a6ee36a8bc2fb8b (diff) tdf#104154 WIP:Add list view to template manager Bisected with: bibisect-linux64-7.2 Adding Cc: to Vert D
*** Bug 138908 has been marked as a duplicate of this bug. ***
On pc Debian x86-64 with master sources updated today + gen rendering, I don't reproduce this but perhaps I missed something.
*** Bug 138940 has been marked as a duplicate of this bug. ***
@Caolán, I thought you might be interested in this issue
right click context menu delete entry crashes, but the "Delete" key deletes without a crash
master only no need for a 7-1 backport: https://gerrit.libreoffice.org/c/core/+/107968
(In reply to Caolán McNamara from comment #10) > master only no need for a 7-1 backport: > https://gerrit.libreoffice.org/c/core/+/107968 If I understand the comment in the patch, it gives an explanation for bug 138940 -- where a template is moved to another category. In Thumbnail View, the moved template is "gone" (not visible in canvas), while in "Localview" it remains visible in the localview list). Click on the "phantom" template in Localview gives a crash.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cd6ddba3e15d2e586cd7b8593d5164aabbbd0dcb tdf#138884 Crash when deleting template via context menu It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #12) > https://git.libreoffice.org/core/commit/cd6ddba3e15d2e586cd7b8593d5164aabbbd0dcb > Affected users are encouraged to test the fix and report feedback. 1. STR no longer give crash (and icon is removed from Listview, which avoids problem in bug 138940), but slow response in canvas update. 2. "Delete" key does not work anymore from Listview (but did before, see also comment 9) -- "Delete" key (still) works in Thumbnail View (but also with slow response). Version: 7.2.0.0.alpha0+ (x64) Build ID: 4041c68ea59181f1c4774c356809066d2051db41 CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win Locale: da-DK (en_DK); UI: en-US Calc: threaded
(In reply to sdc.blanco from comment #13) > 2. "Delete" key does not work anymore from Listview It wasn't working before, I'll work on that.
(In reply to Commit Notification from comment #12) > Affected users are encouraged to test the fix and report feedback. General Problem: false appearance that predefined templates can be deleted in Listview. 1. Choose "Listview" 2. Choose Text Documents (filter) and Styles (category) 3. Delete a template Result: Error message that template cannot be deleted (expected) but then item disappears from listview (not expected). 4. Choose "All Categories" (or another category), then return to "Styles" category. Result: item is "back" (of course it never left, but appearance to user is "wrong"). Additional information: 1. No problem with Thumbnail view (i.e., get cannot delete message, and icon remains on screen). 2. Will be less of an issue because the Delete item in context menu will be greyed out soon. But in principle the "Delete" key should also work, so an appropriate response is still needed.
https://gerrit.libreoffice.org/c/core/+/108365
(In reply to sdc.blanco from comment #15) > 1. Choose "Listview" > 2. Choose Text Documents (filter) and Styles (category) > 3. Delete a template > > Result: Error message that template cannot be deleted (expected) but then > item disappears from listview (not expected). I'm not seeing this in master or in 7.1. Can you check this again?
(In reply to Justin L from comment #17) > > 1. Choose "Listview" > > 2. Choose Text Documents (filter) and Styles (category) > > 3. Delete a template > > > > Result: Error message that template cannot be deleted (expected) but then > > item disappears from listview (not expected). > > I'm not seeing this in master or in 7.1. Can you check this again? Ummm...I would like to help you, but it is impossible for following reasons: Work on bug 138906 and bug 138246 has removed the context menu for deleting predefined templates, and the "Delete" key does not work in Listview at present (see comment 14 here, though comment 9 and comment 13 claim that it was once possible). So I have no way to achieve step 3 (with a relatively current master). fwiw, with thumbnail view, I can use the Delete key, do get a warning message, and the thumbnail remains in view.
No crash with master but starting Draw always shows the warning that the file doesn't exist. It seems to remain the default template since I haven't set any other.
(In reply to Heiko Tietze from comment #19) > No crash with master but starting Draw always shows the warning that the > file doesn't exist. It seems to remain the default template since I haven't > set any other. See bug 101404
Vert D committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/18aa2169c9adf41fa5c9a02ad81d4f68a34509e3 Added delete keyinput to listview, fixed reload() issues: solves tdf#138884 It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.