Created attachment 168144 [details] Screenshot Follow-up to bug 134779. Test with Table > Insert and col>63. Version: 7.2.0.0.alpha0+ Build ID: 07f7afec7832b0d45bef8d883eb3587d06c4673a CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5 Locale: de-DE (en_US.UTF-8); UI: en-US Calc: threaded
SalInstanceEntry::set_message_type is probably what's needed to change here. Though what the solution should be is uncertain.
(In reply to Caolán McNamara from comment #1) > SalInstanceEntry::set_message_type is probably what's needed to change here. > Though what the solution should be is uncertain. Even further at m_xEntry->SetControlForeground(); - it uses COL_TRANSPARENT.
I can't reproduce it on Windows.. I went to Tools -> Options and chose a dark theme.. But I saw black text on yellow background in the InsertTable dialog box..
Please tell if there is some other way to reproduce.. I might be missing something..
(In reply to An-Kh from comment #3) > I went to Tools -> Options and chose a dark theme.. You need to make Windows dark. See https://www.howtogeek.com/222614/how-to-enable-windows-10s-hidden-dark-theme/ (just the first search result).
Hi Please have a look at the following patch : https://gerrit.libreoffice.org/c/core/+/108929
Hi you can also add in line 13243 of file vcl/unx/gtk3/gtk3gtkinst.cxx you can add : set_text_foreground_color(COL_BLUE,true); This will handle any other situation where text color is while anywhere this label is used, and if text color is defined like in your patch that defined color will be used.
(In reply to Caolán McNamara from comment #1) > SalInstanceEntry::set_message_type is probably what's needed to change here. > Though what the solution should be is uncertain. Hi Currently, set_message_type(weld::EntryMessageType::Warning) is being used.. Could you please suggest something else instead of this.. Also, I was thinking that whenever in any code, if set_message_type(weld::EntryMessageType::Warning) is used, this problem will arise.. set_message_type(weld::EntryMessageType::Warning) mostly uses yellow background (as far as high contrast and low contrast are tested).. The problem is with the color of the text displayed on it.. I was thinking to universally change the color of the text displayed if this command is given.. Let me know your thoughts on it :)
(In reply to An-Kh from comment #8) > (In reply to Caolán McNamara from comment #1) > > SalInstanceEntry::set_message_type is probably what's needed to change here. > > Though what the solution should be is uncertain. > > Hi > > Currently, set_message_type(weld::EntryMessageType::Warning) is being used.. > Could you please suggest something else instead of this. I meant that SalInstanceEntry::set_message_type is the place to find to change to do what you want, which seems to be what you have now done. I didn't mean to suggest to change the call of set_message_type to call something else. Your submitted patch looks reasonable to me.
Anshu committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/474398937b5d53d5c7ab30a877f8b663e6963b02 tdf#138890 : weld::LabelType::Warning font color in dark themes It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.