Bug 138958 - Slovenian translation bug
Summary: Slovenian translation bug
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-15 20:50 UTC by Julien Nabet
Modified: 2020-12-17 17:49 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Nabet 2020-12-15 20:50:19 UTC
Description:
In https://dev-builds.libreoffice.org/daily/master/Linux-rpm_deb-x86_64@86-TDF-dbg/current/sl/helpcontent2/source/text/swriter/guide.po
we've got:
  11908 #: registertrue.xhp
  11909 msgctxt ""
  11910 "registertrue.xhp\n"
  11911 "par_id391604248923423\n"
  11912 "help.text"
  11913 msgid "<embedvar href=\"text/shared/00/00000005.xhp#registertrue_intro\"/>        <embedvar href=\"text/shared/00/00000005.xhp#registertrue_in_LO\"/> <embedvar href=\"text/shared/00/00000005.xhp#glossary-pagelinespacing\"/>.        <embedvar href=\"text/shared/00/00000005.xhp#register_purpose\"/>"
  11914 msgstr "<embedvar href=\"text/shared/00/00000005.xhp#registertrue_intro\"/><embedvar href=\"text/shared/00/00000005.xhp#registertrue_in_LO\"/> <variable id=\"glossary-pagelinespacing\"><embedvar href=\"text/shared/00/00000005.xhp#glossary-pagelinespacing\"/>. <embedvar href=\"text/shared/00/00000005.xhp#register_purpose\"/>"

<variable id=\"glossary-pagelinespacing\"> should be removed


Steps to Reproduce:
N/A

Actual Results:
N/A

Expected Results:
N/A


Reproducible: Always


User Profile Reset: No



Additional Info:
N/A
Comment 1 Julien Nabet 2020-12-15 20:51:34 UTC
Martin: one for you?

Detected during build with this error:
Entity: line 1: parser error : Opening and ending tag mismatch: variable line 0 and root
acing"/>. <embedvar href="text/shared/00/00000005.xhp#register_purpose"/></root>
                                                                               ^
Entity: line 1: parser error : EndTag: '</' not found
acing"/>. <embedvar href="text/shared/00/00000005.xhp#register_purpose"/></root>
Comment 2 Julien Nabet 2020-12-15 20:53:27 UTC
Also:
Entity: line 1: parser error : Opening and ending tag mismatch: root line 0 and menuitem
> Za prikaz ravnila izberite &lt;menuitem&quot;&gt;Pogled – Ravnilo</menuitem>
                                                                               ^
Entity: line 1: parser error : Extra content at the end of the document
> Za prikaz ravnila izberite &lt;menuitem&quot;&gt;Pogled – Ravnilo</menuitem>
      
In sl/helpcontent2/source/text/shared/01.po                                            
  18305 msgid "You can also <link href=\"text/swriter/guide/ruler.xhp\" name=\"ruler\">set indents using the ruler</link>. To display the ruler, choose <menuitem>View - Ruler</menuitem>."
  18306 msgstr "<link href=\"text/swriter/guide/ruler.xhp\" name=\"ruler\">Zamike lahko nastavite tudi z ravnilom.</link> Za prikaz ravnila izberite <menuitem\">Pogled – Ravnilo</menuitem>."

There's an extra "\"" in <menuitem\">
Comment 3 Martin Srebotnjak 2020-12-16 19:39:36 UTC
Well, I found one, but could not locate the other one, but I might have updated the po files with later version.
The updated po files for 7.1/master were checked in today so there should be no errors anymore.
Comment 4 Julien Nabet 2020-12-16 19:55:20 UTC
I still got after having used "git pull -r && git submodule update"
commit 129365b9a82c839c794b7747e6148dd0073779cb (HEAD, origin/master, origin/HEAD)
Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Date:   Tue Dec 15 15:01:11 2020 +0100

    update translations for master/7.1.0 rc1
    
    and force-fix errors using pocheck


helpcontent2/source/text/swriter/guide.po

  11913 msgid "<embedvar href=\"text/shared/00/00000005.xhp#registertrue_intro\"/>        <embedvar href=\"text/shared/00/00000005.xhp#registertrue_in_LO\"/> <embedvar href=\"text/shared/00/00000005.xhp#glossary-pagelinespacing\"/>.        <embedvar href=\"text/shared/00/00000005.xhp#register_purpose\"/>"
  11914 msgstr "<embedvar href=\"text/shared/00/00000005.xhp#registertrue_intro\"/><embedvar href=\"text/shared/00/00000005.xhp#registertrue_in_LO\"/> <variable id=\"glossary-pagelinespacing\"><embedvar href=\"text/shared/00/00000005.xhp#glossary-pagelinespacing\"/>. <embedvar href=\"text/shared/00/00000005.xhp#register_purpose\"/>"

=> <variable id=\"glossary-pagelinespacing\"> should be removed

Idem for the other:
  18305 msgid "You can also <link href=\"text/swriter/guide/ruler.xhp\" name=\"ruler\">set indents using the ruler</link>. To display the ruler, choose <menuitem>View - Ruler</menuitem>."
  18306 msgstr "<link href=\"text/swriter/guide/ruler.xhp\" name=\"ruler\">Zamike lahko nastavite tudi z ravnilom.</link> Za prikaz ravnila izberite <menuitem\">Pogled – Ravnilo</menuitem>."

Which one you didn't find?
Comment 5 Martin Srebotnjak 2020-12-16 20:13:52 UTC
Adding Andras.
I hope you are using the right translation, it was checked in today around 18:30 pm CEST.
I will now check my current state of strings and report back.
Comment 6 Martin Srebotnjak 2020-12-16 20:15:16 UTC
Julien, could you please refer to these strings with their ID (like zASUB or whatever it is)?
Comment 7 Martin Srebotnjak 2020-12-16 20:19:59 UTC
I have just checked the latest swriter/guide.po and shared/01.po

I corrected both errors, these are not present in the files I sent to Andras and were checked in today.

Please, make these file available for RC1 builds.
Comment 8 Martin Srebotnjak 2020-12-16 21:44:37 UTC
Maybe your time and date explains this:
Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Date:   Tue Dec 15 15:01:11 2020 +0100

The latest Slovenian files were checked in not from Weblate but directly from my files at around 18:30 by Andras.

Does this mean they will not make it into RC1?
Comment 9 Andras Timar 2020-12-16 22:11:57 UTC
(In reply to Martin Srebotnjak from comment #8)
> Does this mean they will not make it into RC1?

No, I don't see the rc1 tag, so I think we were on time.

The problem is not reproducible on my system with the latest translations.

Fixing commit:

commit ece40d072f96c1b8d2bb2028428cbecc6ebbb0d9 (HEAD -> libreoffice-7-1, origin/libreoffice-7-1)
Author: Andras Timar <andras.timar@collabora.com>
Date:   Wed Dec 16 18:24:47 2020 +0100

    Updated Slovenian translation
    
    Change-Id: Ia1898aa1b2659422d96c1997dac7436f123d12f6
Comment 10 Julien Nabet 2020-12-17 12:30:34 UTC
(In reply to Martin Srebotnjak from comment #6)
> Julien, could you please refer to these strings with their ID (like zASUB or
> whatever it is)?

In Slovenian part, I don't have these strings (whereas I've got them in others).
So it's more difficult to find the string in Weblate.
Comment 11 Julien Nabet 2020-12-17 12:43:18 UTC
here's my output:

julien@debianamd:~/lo/libo_perf$ git branch
* master
julien@debianamd:~/lo/libo_perf$ git pull -r
Already up to date.
julien@debianamd:~/lo/libo_perf$ cd translations/
julien@debianamd:~/lo/libo_perf/translations$ git pull -r
You are not currently on a branch.
Please specify which branch you want to rebase against.
See git-pull(1) for details.

    git pull <remote> <branch>

julien@debianamd:~/lo/libo_perf/translations$ git branch
* (HEAD detached at 129365b9a82)
  master
julien@debianamd:~/lo/libo_perf/translations$ git log -1
commit 129365b9a82c839c794b7747e6148dd0073779cb (HEAD, origin/master, origin/HEAD)
Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Date:   Tue Dec 15 15:01:11 2020 +0100

    update translations for master/7.1.0 rc1
    
    and force-fix errors using pocheck
    
    Change-Id: I64d1494dbed7adfa393e79f9b798725ad8c68350

julien@debianamd:~/lo/libo_perf$ cat .git/config 
[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
[remote "origin"]
	url = ssh://logerrit/core
	#url = https://cgit.freedesktop.org/libreoffice/core/log
	fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
	remote = origin
	merge = refs/heads/master
[submodule "translations"]
	active = true
	url = https://gerrit.libreoffice.org/translations
[submodule "dictionaries"]
	active = true
	url = https://gerrit.libreoffice.org/dictionaries
[submodule "helpcontent2"]
	active = true
	url = https://gerrit.libreoffice.org/help
[protocol]
	version = 2

shouldn't I got the fixed strings?
Comment 12 Martin Srebotnjak 2020-12-17 12:47:54 UTC
If I understand correctly:
your date&time:

Date:   Tue Dec 15 15:01:11 2020 +0100

the date and time updated Slovenian l10n was uploaded by Andras
Tue Dec 15 18:xx 2020

You tested the strings around three hours before the update was uploaded/checked in.
Comment 13 Andras Timar 2020-12-17 13:01:47 UTC
(In reply to Martin Srebotnjak from comment #12)
> 
> You tested the strings around three hours before the update was
> uploaded/checked in.

And he checked master branch, not libreoffice-7-1. I'll push Slovenian translations to master, too.
Comment 14 Julien Nabet 2020-12-17 17:49:10 UTC
(In reply to Andras Timar from comment #13)
> (In reply to Martin Srebotnjak from comment #12)
> > 
> > You tested the strings around three hours before the update was
> > uploaded/checked in.
> 
> And he checked master branch, not libreoffice-7-1. I'll push Slovenian
> translations to master, too.

I updated again my repo I don't have any errors now in Slovenian part.
I hadn't thought that master could be less up-to-date compared to libreoffice-7-1 branch, well done! Any idea how to prevent a potential oversight?