Bug 139102 - Gallery: "Detailed View" icons display is cluttered (GTK3)
Summary: Gallery: "Detailed View" icons display is cluttered (GTK3)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All Linux (All)
: medium minor
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2 tar...
Keywords: bibisected, bisected, regression
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2020-12-20 16:54 UTC by Matthijs Melchior
Modified: 2021-12-06 13:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Windows 10 Screenshot with correct icons (26.64 KB, image/png)
2021-01-04 13:01 UTC, Matthijs Melchior
Details
Linux Sceenshot with garbled icons (26.47 KB, image/png)
2021-01-04 13:05 UTC, Matthijs Melchior
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthijs Melchior 2020-12-20 16:54:33 UTC
Description:
Gallery: “Detailed View” icons  display is cluttered.

Scenario of a good demonstration of the incorrect behavior:

    1. View -> Gallery.
    2. Activate “Detailed View”.
    3. Preview “Arrow-Sketch-1” (double click).
    4. Remember what this looks like and exit preview.
    5. Preview “Arrow-Sketch-2”.
    6. Remember what this looks like and exit preview.
    7. Look at the small icons in the “Detailed View” list.
    8. You will see parts of “Arrow-Sketch-1” in the icon for “Arrow Sketch-2”.
    9. Look further at the small icons, most will show some remains of the previous icons.

My expectation is that the memory area used to create the small icon is not cleared to the transparency background before a new icon is drawn. The assumption that the new icon will fill the area is wrong, it may be smaller…

My expectation of the "Detailed View" list is one with small uncluttered icons.

Steps to Reproduce:
See description

Actual Results:
Cluttered icons in the "Detailed View" list

Expected Results:
Neat uncluttered icons in the "Detailed View" list


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 7.0.4.2
Build ID: 00(Build:2)
CPU threads: 2; OS: Linux 5.9; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Debian package version: 1:7.0.4_rc2-1+b1
Calc: threaded

OpenGL vendor string: X.Org
OpenGL renderer string: AMD RV630 (DRM 2.50.0 / 5.9.0-4-amd64, LLVM 11.0.0)
OpenGL core profile version string: 3.3 (Core Profile) Mesa 20.2.4
OpenGL core profile shading language version string: 3.30
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
OpenGL core profile extensions:
OpenGL version string: 3.0 Mesa 20.2.4
OpenGL shading language version string: 1.30
OpenGL context flags: (none)
OpenGL extensions:
OpenGL ES profile version string: OpenGL ES 3.0 Mesa 20.2.4
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.00
OpenGL ES profile extensions:
Comment 1 Dieter 2021-01-04 08:06:13 UTC
I can't confirm with

Version: 7.2.0.0.alpha0+ (x64)
Build ID: c0eee433e079d8e3413f4691607e075b99af92b0
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
Comment 2 Matthijs Melchior 2021-01-04 13:01:32 UTC
Created attachment 168663 [details]
Windows 10 Screenshot with correct icons
Comment 3 Matthijs Melchior 2021-01-04 13:05:02 UTC
Created attachment 168664 [details]
Linux Sceenshot with garbled icons
Comment 4 Matthijs Melchior 2021-01-04 13:07:46 UTC
I found myself a Windows 10 machine to see how it looks there.

Its OK on Windows...

Just made 2 screenshots of the details, on Windows and on Debian Linux, to show the difference.
Comment 5 Buovjaga 2021-11-25 15:48:11 UTC
Repro only with GTK3 backend.

Bibisected with linux-64-7.0 to
https://git.libreoffice.org/core/commit/b4b6daf8b70a5448d3e7aea440d56d95e19e7d2d

make gallery listview seem faster to populate

Adding Cc: to Caolán McNamara
Comment 6 Caolán McNamara 2021-11-25 17:14:28 UTC
Erase with COL_TRANSPARENT doesn't work as one would hope it should.
Comment 7 Commit Notification 2021-11-26 08:50:32 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/23662e4ca69386c14425798f1e9d80ff803fb7cc

tdf#139102 Erase with COL_TRANSPARENT doesn't do what it should

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Caolán McNamara 2021-11-26 10:20:04 UTC
done in trunk, backport to 7-2 and 7-3 in gerrit
Comment 9 Buovjaga 2021-11-26 14:01:39 UTC
Verified, thanks

Arch Linux 64-bit
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: b18c2a0024c6d33cdf142ed2adf0d127483411e8
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 26 November 2021
Comment 10 Commit Notification 2021-11-26 19:19:33 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/368c9f4721bcb7b5e373321868f2af249f12fcfc

tdf#139102 Erase with COL_TRANSPARENT doesn't do what it should

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-11-27 16:48:18 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/f2b7b0efba1ffc22b987563a5df339282018bc7a

tdf#139102 Erase with COL_TRANSPARENT doesn't do what it should

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Christian Lohmaier 2021-12-06 13:30:12 UTC
7.2.4 was a hotfix release, updating target in status-whiteboard