Bug 139170 - Make OutputDevice::EmulateDrawTransparent(() redundant
Summary: Make OutputDevice::EmulateDrawTransparent(() redundant
Status: NEEDINFO
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: All other
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Dev-related
  Show dependency treegraph
 
Reported: 2020-12-22 20:26 UTC by Chris Sherlock
Modified: 2025-03-04 11:24 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Sherlock 2020-12-22 20:26:21 UTC
Description:
We currently have a function OutputDevice::EmulateDrawTransparent(). This is used because OutputDevice::DrawTransparentNatively() can fail, because a number of our VCL backends don't guarantee the drawing of PolyPolygons and PolyPolylines. 


We need the following backends to guarantee the drawing of PolyPolygons:

* X11SalGraphicsImpl::drawFilledTrapezoids()
* GenPspGraphics::drawPolyPolygon()

The following backends need to guarantee the drawing of PolyLines:

* X11SalGraphicsImpl::drawPolyLine()
* GenPspGraphics::drawPolyLine()
* AquaSalGraphics::drawPolyLine() - note this can only fail if using IOS


Steps to Reproduce:
n/a

Actual Results:
n/a

Expected Results:
n/a


Reproducible: Always


User Profile Reset: No



Additional Info:
We can basically remove OutputDevice::EmulateDrawTransparent() and then collapse OutputDevice::DrawTransparentNatively() into OutputDevice::DrawTransparent(). 

This will remove a lot of code that currently needs to be maintained. It will hopefully speed up things also.
Comment 1 Telesto 2020-12-23 09:05:21 UTC
FWIW: Some vague recollection X11 will be unsupported/dropped (don't take my word for it though)

Related to IOS.. - political talk - hope all those bit of pieces related macOS/IOS  rendering add up to make Skia a logical solution :-)
Comment 2 Xisco Faulí 2025-03-04 11:21:22 UTC
Hello,
It's been a while since this issue was reported.
Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version.