Bug 139170 - Make OutputDevice::EmulateDrawTransparent(() redundant
Summary: Make OutputDevice::EmulateDrawTransparent(() redundant
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: All other
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Dev-related
  Show dependency treegraph
 
Reported: 2020-12-22 20:26 UTC by Chris Sherlock
Modified: 2025-11-25 15:31 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Sherlock 2020-12-22 20:26:21 UTC
Description:
We currently have a function OutputDevice::EmulateDrawTransparent(). This is used because OutputDevice::DrawTransparentNatively() can fail, because a number of our VCL backends don't guarantee the drawing of PolyPolygons and PolyPolylines. 


We need the following backends to guarantee the drawing of PolyPolygons:

* X11SalGraphicsImpl::drawFilledTrapezoids()
* GenPspGraphics::drawPolyPolygon()

The following backends need to guarantee the drawing of PolyLines:

* X11SalGraphicsImpl::drawPolyLine()
* GenPspGraphics::drawPolyLine()
* AquaSalGraphics::drawPolyLine() - note this can only fail if using IOS


Steps to Reproduce:
n/a

Actual Results:
n/a

Expected Results:
n/a


Reproducible: Always


User Profile Reset: No



Additional Info:
We can basically remove OutputDevice::EmulateDrawTransparent() and then collapse OutputDevice::DrawTransparentNatively() into OutputDevice::DrawTransparent(). 

This will remove a lot of code that currently needs to be maintained. It will hopefully speed up things also.
Comment 1 Telesto 2020-12-23 09:05:21 UTC
FWIW: Some vague recollection X11 will be unsupported/dropped (don't take my word for it though)

Related to IOS.. - political talk - hope all those bit of pieces related macOS/IOS  rendering add up to make Skia a logical solution :-)
Comment 2 Xisco Faulí 2025-03-04 11:21:22 UTC
Hello,
It's been a while since this issue was reported.
Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version.
Comment 3 QA Administrators 2025-09-01 03:11:35 UTC Comment hidden (obsolete)
Comment 4 QA Administrators 2025-11-25 15:31:47 UTC
Dear Chris Sherlock,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp