Bug 139182 - "Symbol" shows up twice in "Visible Buttons"
Summary: "Symbol" shows up twice in "Visible Buttons"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.4.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks:
 
Reported: 2020-12-23 10:15 UTC by Dan Dascalescu
Modified: 2021-01-13 13:24 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Screenshot (72.69 KB, image/png)
2020-12-23 10:15 UTC, Dan Dascalescu 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Dascalescu 2020-12-23 10:15:10 UTC 
Created attachment 168448 [details]
Screenshot

Right click on a toolbar button, then choose "Visible Buttons". Notice how "Symbol" shows up twice.
Comment 1 Julien Nabet 2020-12-23 10:52:54 UTC 
On pc Debian x86-64 with LO Debian package 7.0.4, I could reproduce this.

Heiko/Xisco: thought you might be interested in this one.
Comment 2 Julien Nabet 2020-12-23 11:27:29 UTC 
I used keyid and searched in French translation part.
One corresponds to:
  23182 #. oBjzB
  23183 #: GenericCommands.xcu
  23184 msgctxt ""
  23185 "GenericCommands.xcu\n"
  23186 "..GenericCommands.UserInterface.Commands..uno:InsertSymbol\n"
  23187 "Label\n"
  23188 "value.text"
  23189 msgid "Symbol"
  23190 msgstr "Symbole"

the other:
  23212 #. KXPE3
  23213 #: GenericCommands.xcu
  23214 msgctxt ""
  23215 "GenericCommands.xcu\n"
  23216 "..GenericCommands.UserInterface.Commands..uno:CharmapControl\n"
  23217 "Label\n"
  23218 "value.text"
  23219 msgid "Symbol"
  23220 msgstr "Symbole"

both are in officecfg/registry/data/org/openoffice/Office/UI.po
Comment 3 Heiko Tietze 2021-01-04 11:46:44 UTC 
The hidden "Symbol" button is what we had before 2017 [1], and what is accessed now per "More Characters..." from the floating widget. Perhaps it's time to remove this hidden button from the toolbar.

Code pointer:

<toolbar:toolbaritem xlink:href=".uno:InsertSymbol" toolbar:visible="false"/>

in 

/core/sw/uiconfig/swform/toolbar/standardbar.xml
/core/sw/uiconfig/sweb/toolbar/standardbar.xml
/core/sw/uiconfig/swriter/toolbar/standardbar.xml
/core/sw/uiconfig/sglobal/toolbar/standardbar.xml
/core/sw/uiconfig/swxform/toolbar/standardbar.xml
/core/sc/uiconfig/scalc/toolbar/standardbar.xml

[1] https://akkidevblog.wordpress.com/2017/08/21/gsoc-2017-work-product/
Comment 4 Commit Notification 2021-01-13 13:24:08 UTC 
Vishwas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/84ecc3ae43815a33b6b76349c5b5a7097dd329e6

tdf#139182 "Symbol" shows up twice in "Visible Buttons"

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.