Bug 139299 - EDITING: Closing of query from design view leads to crash
Summary: EDITING: Closing of query from design view leads to crash
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
7.1.0.1 rc
Hardware: x86-64 (AMD64) Linux (All)
: high major
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0 target:7.1.0.2
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks:
 
Reported: 2020-12-29 07:20 UTC by Robert Großkopf
Modified: 2021-01-14 10:43 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
bt with debug symbols (kf5) (7.54 KB, text/plain)
2020-12-29 09:24 UTC, Julien Nabet
Details
bt with debug symbols (gen rendering) (7.50 KB, text/plain)
2020-12-29 09:32 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2020-12-29 07:20:39 UTC
Open any database file.
Go to "Queries"  → "Create Query in Design View …"
Create a query and test this query and run this query (Edit → Run Query [F5]) in design view.
There is no content shown in the query.

This is https://bugs.documentfoundation.org/show_bug.cgi?id=139298.

Now try to close design view. 
Every time I tested this it leads to a crash of whole LO.

This bug happens every time in LO 7.1.0.1 on OpenSUSE 15.2 64bit rpm Linux.
Comment 1 Robert Großkopf 2020-12-29 07:59:27 UTC
I tested it a little bit more.
If I don't save the query before I want to close the query I will be asked by a dialog if I want to save the query. This way the query will be saved and LO won't crash.

If I save the query before I try to close the query (File → Save) it will crash immediately when I close the query.
Comment 2 Julien Nabet 2020-12-29 09:24:30 UTC
Created attachment 168551 [details]
bt with debug symbols (kf5)

On pc Debian x86-64 with master sources updated today + kf5 rendering, I could reproduce this.
Comment 3 Julien Nabet 2020-12-29 09:32:57 UTC
Created attachment 168552 [details]
bt with debug symbols (gen rendering)
Comment 4 Julien Nabet 2020-12-29 09:42:09 UTC
I don't reproduce this with gtk3 rendering.

Caolán: thought you might be interested in this one.
Comment 5 Aron Budea 2021-01-01 09:20:35 UTC
This started with the same two commits as bug 139298.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5f7cf9ccba25a94c275ec67936dc29f0adb4129a
author		Caolán McNamara <caolanm@redhat.com>	2020-08-10 19:49:25 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2020-08-12 20:22:23 +0200

"use InterimDBTreeListBox"

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7b314c6aceb51d01b9b4314764b0f5852b4fb655
author		Caolán McNamara <caolanm@redhat.com>	2020-08-10 21:05:46 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2020-08-12 20:22:41 +0200

"drop now unused DBTreeListBox"
Comment 6 Aron Budea 2021-01-01 09:24:05 UTC
For the record, for me it only crashes if I save the query first before closing the query design view, if I choose to save when it asks during closing, or don't save the query at all, it doesn't crash.
Comment 7 Robert Großkopf 2021-01-01 10:33:37 UTC
(In reply to Aron Budea from comment #6)
> For the record, for me it only crashes if I save the query first before
> closing the query design view, if I choose to save when it asks during
> closing, or don't save the query at all, it doesn't crash.

It is the same behavior I detected. See comment 1.
Comment 8 Commit Notification 2021-01-14 09:11:02 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/45ef56be4febb73924ccc1a1902adf53f00a20ce

Resolves: tdf#139299 crash on gaining focus during dispose

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Caolán McNamara 2021-01-14 09:12:20 UTC
fixed in master, backport to 7-1 in gerrit
Comment 10 Commit Notification 2021-01-14 10:43:00 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/37624d87110ca5f5990983ab73a2cd962d81d51a

Resolves: tdf#139299 crash on gaining focus during dispose

It will be available in 7.1.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.