Bug 139339 - Unify protect/unprotect cases for document protection as implemented in sheet protection
Summary: Unify protect/unprotect cases for document protection as implemented in sheet...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: An-Kh
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-31 14:30 UTC by An-Kh
Modified: 2021-01-05 20:37 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description An-Kh 2020-12-31 14:30:02 UTC 
Unifying things for document protection as implemented for sheet protection in

https://gerrit.libreoffice.org/c/core/+/107041
Comment 1 An-Kh 2020-12-31 14:38:38 UTC 
(In reply to An-Kh from comment #0)
> Unifying things for document protection as implemented for sheet protection
> in
> 
> https://gerrit.libreoffice.org/c/core/+/107041

It is implemented under ScDocFunc::ProtectSheet 
The proposal is to create a similar function for document protection (something like ScDocFunc::ProtectDocument)
Comment 2 An-Kh 2021-01-01 06:00:36 UTC 
Please review this patch

https://gerrit.libreoffice.org/c/core/+/108541
Comment 3 Commit Notification 2021-01-05 16:13:20 UTC 
Anshu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5c97d7f490f82152ff42bf61f5a4b270f0141ba2

tdf#139339 : Unify protect/unprotect cases for document protection

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.