Bug 139379 - Angle in option "Point reduction" is off by factor 100
Summary: Angle in option "Point reduction" is off by factor 100
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords: bibisectRequest, regression
Depends on:
Blocks:
 
Reported: 2021-01-03 00:59 UTC by Regina Henschel
Modified: 2021-01-04 20:44 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Testdocument to reproduce the error (11.57 KB, application/vnd.oasis.opendocument.graphics)
2021-01-03 00:59 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2021-01-03 00:59:52 UTC
Created attachment 168638 [details]
Testdocument to reproduce the error

In case you do not know, how interactive point reduction works:
1. Open attached document in an older version, LO 7.0 for example. Make sure no snap is enabled.
2. Go to Tools > Options > Draw > Grid and enter 40° into the field "Point reduction". OK.
3. Select the red polygon. Switch to point edit mode. That is an icon in the toolbar. In case the toolbar "Edit points" has not opened automatically, open it via menu View > Toolbars.
4. Enable "Eliminate Points". That is the right most icon in "Edit points" toolbar.
5. Grab the point P and drag it toward the circle. If it crosses the circle, the point is eliminated.
The circle is so constructed, that the sum of the angles in points S and T of the triangle SAT is 40° and same for the triangle SBT.
A point P is eliminated, if the sum of the angles in its neighbor points S and T in the triangle STP is smaller than the angle set in "Point reduction".

Now open the file in a LibreOffice Dev daily, for example from 31.Dez.
Enter angle 0,4° in "Point reduction" field.
Now do steps 3 to 5. Notice that elimination happens at the circle, so as if the point reduction angle would be 40°.

Try to enter 40° in field "Point reduction". It will jump to 0°.

Now open the file in a LibreOffice Dev from Today (3.Jan.) and enter 40° in field "Point reduction". LibreOffice crashes.

The problem was likely introduced with the Degree100 work. Noel, please have a look.
Comment 1 Commit Notification 2021-01-03 10:09:48 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ceba98a4f7712cf015d27370ef00df003b4955d2

tdf#139380 tdf#139379 Constrain object when rotating angle is off by factor 100

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Regina Henschel 2021-01-03 15:20:40 UTC
Not fixed, values in the Options dialog react wrongly. See comment in bug 139380.
Comment 3 Commit Notification 2021-01-04 06:47:11 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7f633ac437c1ed1880ab801e8d027240074d646b

tdf#139380 tdf#139379 followup

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Regina Henschel 2021-01-04 20:44:52 UTC
Seen OK in my build Version: 7.2.0.0.alpha0+ (x64)
Build ID: 2ffa6c897379bf07367d445918b4c142cd493e7f
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL