Description: Scrolling document with images extremely slow (GTK3) Steps to Reproduce: 1. Open attachment 168485 [details] 2. Zoom in & scroll Actual Results: Doesn't even move Expected Results: state prior to the commit (still sub-optimal). Skia has nice optimizations Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.beta1+ Build ID: e2cffcf55b04838abc7497f6c18518c7600b670b CPU threads: 2; OS: Linux 5.3; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Created attachment 168640 [details] Bibisect log Bisected to: author Mike Kaganski <mike.kaganski@collabora.com> 2020-08-13 18:12:37 +0300 committer Mike Kaganski <mike.kaganski@collabora.com> 2020-08-14 01:00:04 +0200 commit bf021c369f2306ee507da9bd3cc4cd10ac5d234c (patch) tree a3dc2552801cfe31cb524c6f375980eaa48e844b parent 56d5531373cf0588e02c254ea8ffa00221c8342b (diff) tdf#135500: always use transparent and clear content vdev in impBufferDevice This removes the only place that hadn't used transparent impBufferDevice yet - in VclProcessor2D::RenderMaskPrimitive2DPixel. Not clearing the vdev made it draw on whatever garbage was left there from previous paints when the buffer was taken from maFreeBuffers in VDevBuffer::alloc, so since this was also the only place left that didn't clear the buffer explicitly, this makes the clear unconditional in impBufferDevice ctor. Also this makes sure to clear proper rectangle in VDevBuffer::alloc, and to clear mpAlphaVDev in OutputDevice::Erase. https://cgit.freedesktop.org/libreoffice/core/commit/?id=bf021c369f2306ee507da9bd3cc4cd10ac5d234c
@Buovjaga Some time to do a quick confirmation?
Confirmed the bibisect result with linux-64-7.1 repo
Adding CC: to Mike Kaganski Note: bug 138068 makes the more prominent; that one needs to go first.. maybe this one gets solved too that way
Hi Telesto, Could you please try again with a daily build from http://dev-builds.libreoffice.org/daily/master/ containing the fix for bug 138068 < https://git.libreoffice.org/core/commit/27a4aea50a9efa5c839b0ae2de1f9f14a7782f11 >
Setting to unconfirmed for now.. Buovjaga, you probably setup to test more quickly (I have to boot my VirtualBox and update everything to Master)
(In reply to Telesto from comment #6) > Setting to unconfirmed for now.. Buovjaga, you probably setup to test more > quickly (I have to boot my VirtualBox and update everything to Master) I checked with Linux 7.2 repo and while the particular mentioned commit does not seem to be the fixing one, the performance is now fine with gtk3! For reference, the commit in the repo is commit 9bcda00693f9b368e2195b61ad016b92f41d3eeb Author: Jenkins Build User <tdf@pollux.tdf> Date: Fri Feb 12 14:36:11 2021 +0100 source 9d89d98d3349502b56da4bdd6ea287ac4cde9ce5 source 9d89d98d3349502b56da4bdd6ea287ac4cde9ce5
WFM as we don't know the commit