Description: UI: Thumbnail in start center shows changes. Hidden expected Steps to Reproduce: 1. Open attachment 162927 [details] 2. Edit -> track changes -> Show changes 3. Close document 4. Look at start center thumbnail 5. Open document Actual Results: Thumbnail shows 'show track changes' whereas on opening this not being the case Expected Results: Thumbnail should show document with changes hidden Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) Build ID: f2171af6ce3516598d9f8bac8294025a21a5b1a2 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Also in Version: 6.2.4.0.0+ Build ID: 5c5eab3522368d6baa7ab6ef1b6c9f5eaaab4fad CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL still ok in Versie: 6.0.4.1 Build ID: a63363f6506b8bdc5222481ce79ef33b2d13c741 CPU-threads: 4; Besturingssysteem: Windows 6.3; UI-render: GL; Locale: nl-NL (nl_NL); Calc: CL
I confirm it with Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL
This started in 6.3 (backported to 6.2) with author Michael Stahl on 2018-12-18 17:55:30 +0100 commit 32902f66e7749b2d06d13f50416be5323a0c0ea9 sw_redlinehide: make layout based Show/Hide mode the default The difference is that prior to the commit, the user was asked if they wanted to save the document on exit. No meant that the thumbnail was not updated. Now you can close the document without being asked to save. But something is regenerating the thumbnail.
(In reply to Justin L from comment #3) > But something is regenerating the thumbnail. Apparently, it always has on document close. (Apparently a cancelled save bypasses this.) case SfxEventHintId::OpenDoc: case SfxEventHintId::SaveDocDone: case SfxEventHintId::SaveAsDocDone: case SfxEventHintId::SaveToDocDone: case SfxEventHintId::CloseDoc: { AddDocumentToPickList(pDocSh); } So always on close, the thumbnail is updated if not modified. (Not sure why, but from 2001 when this was all revised, on CloseDoc was the only item in this list.) Perhaps now that open/save cover this, we could remove the closeDoc case completely? Not sure what purpose it serves to remain here. No unit test failures occurred when removing case SfxEventHintId::CloseDoc: http://gerrit.libreoffice.org/c/core/+/126649
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still present in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 40617d867346956588ac023511f31210107217f4 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL threaded
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1f6d845e10737d6ad1fec1c0ff660baae0ce3f3c tdf#139636 thumbnail: don't regenerate on file close It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
thanks Justin for fixing this
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/c806266613b5a110caa6a50327d264173d6a17d5 tdf#139636 thumbnail: don't regenerate on file close It will be available in 24.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.