Bug 139654 - Enhancement request for sensitive 'Features...' buttons in Character Font tab page
Summary: Enhancement request for sensitive 'Features...' buttons in Character Font tab...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha1+
Hardware: All All
: medium enhancement
Assignee: Deb
URL:
Whiteboard: target:7.3.0
Keywords: difficultyMedium, easyHack, skillCpp, topicUI
Depends on:
Blocks: Character-Dialog
  Show dependency tree / graph
 
Reported: 2021-01-15 21:46 UTC by Jim Raykowski
Modified: 2021-07-20 03:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2021-01-15 21:46:25 UTC 
Hi All,

When a font has no features and the Features... button is pressed, a dialog showing only the font preview is displayed. It is possible to make the button sensitive to whether the the font has features or not.

Steps to repro using Writer:

1) Open Writer
2) Menu > Format > Character... > Font tab
3) Using any of the Text Font Family combo boxes select any font family that has no font features, e.g. Lohit Bengali
4) Click Font Features... button

Result: Font Features dialog box shows preview of font with no features to select

Proposal is to disable the Features... button for fonts with no features.
Comment 1 Roman Kuznetsov 2021-01-16 19:44:06 UTC 
just +1
Comment 2 Heiko Tietze 2021-01-19 12:13:56 UTC 
Yes, but the disabled button should give a feedback why it's not possible to run the action. Meaning if sensitive is false a tooltip is assigned.
Comment 3 Heiko Tietze 2021-01-19 12:14:19 UTC 
Sounds like an easyhack...
Comment 4 Jim Raykowski 2021-01-20 01:37:30 UTC 
Code pointers:

To learn how to know if there are font features available for a font 
see cui/source/dialogs/FontFeaturesDialog.cxx
void FontFeaturesDialog::initialize()

In cui/source/tabpages/chardlg.cxx 
SvxCharNamePage::UpdatePreview_Impl()
set the sensitivity and tool tip for: 
m_xWestFontFeaturesButton
m_xEastFontFeaturesButton
m_xCTLFontFeaturesButton
Comment 5 Deb 2021-02-03 04:59:06 UTC 
I will try to fix this bug.
Comment 6 Deb 2021-07-15 04:55:04 UTC 
I have a change pending at https://gerrit.libreoffice.org/c/core/+/118965
Comment 7 Commit Notification 2021-07-16 07:03:30 UTC 
Deb Barkley-Yeung committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/44db9f08077f388306ef0bf7277c93a1e5cd89b8

tdf#139654 Font feature sensativity

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Jim Raykowski 2021-07-20 03:31:53 UTC 
@Deb, Great work on the enhancement!

In Comment 2 Heiko recommends a tooltip when the selected font has no available font features. Possibly something like "The selected font has no available font features"

code pointers:
weld::Button::set_tooltip
SvxResId
cui/inc/strings.hrc
Comment 9 Jim Raykowski 2021-07-20 03:36:57 UTC 
code pointer weld::Button:set_tooltip should have been:

weld::Button::set_tooltip_text