Bug 139665 - Direct paste in comment box using context menu not possible, disappears
Summary: Direct paste in comment box using context menu not possible, disappears
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All All
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Toolbars-Context-Menu
  Show dependency treegraph
 
Reported: 2021-01-16 09:02 UTC by Telesto
Modified: 2022-05-10 18:35 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screencast (2.69 MB, video/mp4)
2021-08-04 14:10 UTC, Telesto
Details
Bibisect log (3.38 KB, text/plain)
2022-05-10 18:32 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-01-16 09:02:54 UTC
Description:
Direct paste in comment box using context menu not possible, disappears

Steps to Reproduce:
1. Look at attachment 147928 [details]
2. Repeat the paste on Windows as soon

Actual Results:
Not possible

Expected Results:
Directly paste should be possible


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: f2171af6ce3516598d9f8bac8294025a21a5b1a2
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-01-16 09:36:54 UTC
Also found din
Version: 6.2.4.0.0+
Build ID: 5c5eab3522368d6baa7ab6ef1b6c9f5eaaab4fad
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

working as expected in
Version: 5.4.0.3
Build ID: 7556cbc6811c9d992f4064ab9287069087d7f62c
CPU threads: 4; OS: Windows 6.2; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL
Comment 2 samarthupadhya2309 2021-02-08 01:48:18 UTC
Bug not reproduced and everything worked normally and I could successfully paste.

Version: 6.4.6.2
Build ID: 1:6.4.6-0ubuntu0.20.04.1
CPU threads: 6; OS: Linux 5.8; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 3 Natali Eroshenko 2021-08-04 13:56:41 UTC
don`t repro in
Version: 7.1.5.2 (x64) / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 6; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (ru_RU); UI: en-US
Calc: threaded.
Comment 4 Telesto 2021-08-04 14:10:56 UTC
Created attachment 174075 [details]
Screencast

Apparently depends on the speed.. If you hoover above the comment box first for 2 sec and press right click it will work.. but in case you are doing this fast, the comment box will close
Comment 5 Jean-Baptiste Faure 2022-05-10 16:53:19 UTC
(In reply to Telesto from comment #4)
> Created attachment 174075 [details]
> Screencast
> 
> Apparently depends on the speed.. If you hoover above the comment box first
> for 2 sec and press right click it will work.. but in case you are doing
> this fast, the comment box will close

I confirm this behavior on Version: 7.3.4.0.0+ / LibreOffice Community
Build ID: 4500514571e389dec40f90d9d40dc568d5e4c490
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Ubuntu_20.04_x86-64
Calc: threaded

Set status to NEW.

@telesto: could you provide the number of last working version to confirm the keyword regression?

Best regards. JBF
Comment 6 Telesto 2022-05-10 18:01:43 UTC
(In reply to Jean-Baptiste Faure from comment #5)
> @telesto: could you provide the number of last working version to confirm
> the keyword regression?
> 
> Best regards. JBF

For the most part covered by comment 1, but checked again

Checked again, it's good in
Version: 6.0.0.0.alpha0+
Build ID: 9127d1a89cbfba89eb9df6755ea7b9e161cfc67a
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL

bad in 6.1

It's probably more where you right click (instead of speed). If you right click exactly on the cursor it works, even today. 
In the past (prior 6.1) you could right click somewhere within the yellow area and it worked..
Comment 7 Telesto 2022-05-10 18:32:19 UTC
Created attachment 180045 [details]
Bibisect log

Bisected to

author	Armin Le Grand <Armin.Le.Grand@cib.de (CIB)>	2018-03-01 15:54:32 +0100
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2018-04-06 22:29:02 +0200
commit 6c14c27c75a03e2363f2b363ddf0a6f2f46cfa91 (patch)
tree e66f50adb222dbc1490b4df2d3c63541dad999ac
parent e1b247a843c5eb850fe0079819239d9883412d38 (diff)
SOSAW080: Added first bunch of basic changes to helpers
SOSAW080: Make SdrModel& prerequisite to SdrObjects

Added need for SdrModel& in constructors of SdrModel,
SdrPage, SdrView and SdrObjList. Builds, not finished.

SOSAW080: removed and replaced old SdrModel

Removed and replaced GetModel()/SetModel() in all using
classes (SdrObject, SdrPage, SdrView), added accessors
to new referenced SdrModel, adapted all accessing places.
Refactored/Extended ::Clone and ::operator== for these
classes to allow cloning objects to a target SdrModel.
Adapted places where this is done AFAP. Added quite some
comments (tagged with 'TTTT') where possible further work
is needed. Builds completely, thus checking in. This does
not mean that this change is done yet.

SOSAW080: Adapted SdrPage/SdrModel relationship

Also needed to work on copy-construction of SdrPage and hierarchy,
quite some stuff removed, no copy-constructor anymore, no
MigrateItemPool stuff. Builds well, test stuck, will need
some cleanup/finetunung

SOSAW080: Smaller corrections/includes adapted

SOSAW080: Smaller corrections/includes adapted

SOSAW080: Debugging/Stabilizing/MakeUnitTestWork

SOSAW080: Stabilized for UnitTests, cleanups

SOSAW080: Adapted GetObjGraphic to just take a const SdrObject&

SOSAW080: Removed ChangeModel from classes

Classes SvxTextEditSource and SvxDrawPage (including
TextEditSource stuff) do not need change of SdrModel
anymore.

SOSAW080: Adapted some comments to make more readable

SOSAW080: Corrected constructor

SOSAW080: getSdrModelFromUnoModel added override marks

SOSAW080: Added missing includes

SOSAW080: Corrected SdrPage constructor

SOSAW080: Corrected some SdrObject::Clone scenarios

Especially when cloning to another SdrModel and taking
the sdr::properties into account.

SOSAW080: Added include for Mac-Build

SOSAW080: Added Scale to DefaultProperties

If a SdrModel change happens in DefaultProperties copy
constructor (used from Clone()), potentially a Scale
for the SfxItems has to be done.

SOSAW080: Added missing include for MacBuild

SOSAW080: Corrected CppunitTest_sc_anchor_test

An adaption of a SdrPathObj instantiation was missing,
added that. Seems as if that test is no tpart of the
usual 'make' scenario, but used/executed in gerrit builds

SOSAW080: Reworked SvxShape to use SdrObject's SdrModel

SOSAW080: Reworked SvxShape to use SdrObject's SdrModel

SOSAW080: Free SdrObjects when SdrModel goes down

In an UNO API test problem is that SvxShapes reference
SdrShapes, but these are not added to a SdrPage and not
'owned' by the SvxShape. Thus these do not get deleted
at all (same in master, memory leak). I extended
SvxShape::Notify the case for ModelCleared to also
Free the SdrObject when not owner and it's not added to
a SdrPage (in that case it gets deleted with deleting
the SdrModel)

SOSAW080: Solve UNO API calls that move SvxShapes to other Model

Due to UNO API tests I got a call to insert an xShape to a
xDrawPage which was constructed in another Model, this has now to
be done by Cloning the SdrObject to the new SdrModel, getting
rid of the old one and getting all the UNO implementation
stuff right (referemces SdrObject <-> xShape).
Comment 8 Telesto 2022-05-10 18:35:21 UTC
It's not really a regression. The comment box increased in size; it's now a true box today, in the past a single line rectangle

However right clicking only works for paragraph line, if you click below the cursor position the whole comment box disappears. So the 'box' (square) makes the problem more apparent