Bug 139699 - useless blue decoration in "3D Effects" dialog
Summary: useless blue decoration in "3D Effects" dialog
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium minor
Assignee: Katarina Behrens
URL:
Whiteboard: target:7.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-01-17 10:31 UTC by Regina Henschel
Modified: 2021-04-24 01:55 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Screenshot of wrong 3D Effects dialog (35.33 KB, image/png)
2021-01-17 10:31 UTC, Regina Henschel 		Details
Screenshot of Correct 3D Effects (27.71 KB, image/png)
2021-01-17 10:32 UTC, Regina Henschel 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2021-01-17 10:31:25 UTC 
Created attachment 168948 [details]
Screenshot of wrong 3D Effects dialog

The "3D Effects" dialog has a useless blue decoration in current master. Please remove it, the dialog is already large.

I see the error in Version: 7.2.0.0.alpha0+ (x64)
Build ID: 9f9798f07f0b56ae474f31ded671cc8da598d244
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL

It is OK in Version: 7.0.0.2 (x64)
Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL
Comment 1 Regina Henschel 2021-01-17 10:32:17 UTC 
Created attachment 168949 [details]
Screenshot of Correct 3D Effects
Comment 2 Xisco Faulí 2021-01-28 09:33:14 UTC 
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5da3ae08596c2465532e662537f5292454a84a3e

author	shubham656 <shubham656jain@gmail.com>	2020-12-21 19:15:56 +0530
committer	Heiko Tietze <heiko.tietze@documentfoundation.org>	2021-01-05 07:57:03 +0100
commit 5da3ae08596c2465532e662537f5292454a84a3e (patch)
tree c377114e86d9cccdff611b3f75e3f01c78af6de3
parent 9b02ff6a6a95b73c103f998716d1c9df61b41ff5 (diff)
tdf#131427 Remove button "Texture, Shadow and Color" in 3D Effects dialog

Bisected with: bibisect-linux64-7.2

Adding Cc: to shubham656
Comment 3 Heiko Tietze 2021-01-28 13:51:38 UTC 
(In reply to Xisco Faulí from comment #2)
> Regression introduced by:
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=5da3ae08596c2465532e662537f5292454a84a3e

This patch only removes content. Sure you found the right patch?
Comment 4 Commit Notification 2021-04-23 23:16:27 UTC 
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b38fd085608a44cf3a2d181e2720c758356647d7

tdf#139699: remove stray image that is not used anywhere

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Adolfo Jayme Barrientos 2021-04-24 01:55:09 UTC 
Nicely spotted, Katarina!