Description: UI: Underline split button in regular toolbar Steps to Reproduce: 1. Open Writer 2. Go to tabbed mode 3. Go to home -> Take look at underline -> has split button with arrow down 4 This isn't present in regular toolbar. Actual Results: No split button Expected Results: Expected.. is pretty strong.. this kind of 'unconventional', but maybe nice to have.. Not seeing big problem with it. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) Build ID: f2171af6ce3516598d9f8bac8294025a21a5b1a2 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
The classic toolbar has .uno:UnderlineSingle while the Notebookbar and the sidebar uses the .uno:Underline command, which provides a more complex menu button with all kind of underlining options. Do we need this complexity in the standard UI?
(In reply to Heiko Tietze from comment #1) > The classic toolbar has .uno:UnderlineSingle while the Notebookbar and the > sidebar uses the .uno:Underline command, which provides a more complex menu > button with all kind of underlining options. Do we need this complexity in > the standard UI? This kind of 'depends'. I personally find it 'easy' tool to play with underlining. Which a lot more accessible compared to the dialog approach. I considered it lacking after I encountered inside the tabbed edition. But before I never considered looking for it. So 'traditional' - old skool - approach, this obviously a no go. But well 'it's' only a drop down button. Major complain would be (a) aesthetical; Only Underlining having it.. (b) and the obvious why bold/italic lacking it.. The first encounter would surely be surprise. People obviously clicking the 'drop down' button.. But I would expect the response to be, o nice.. Or else 'shrug', don't need that, but doesn't bother me. But that's me reasoning.. not sure how others perceive this.. I don't see no harm, IMHO. Only advantage..
+1 for .uno:Underline in the Toolbar
+1 the drop down arrow also helps to distinguish to the next right set of tools
Clear acceptance, let's do it.
In sw/uiconfig/*/toolbar/textobjectbar.xml the line <toolbar:toolbaritem xlink:href=".uno:UnderlineSimple"/> needs to be replaced by <toolbar:toolbaritem xlink:href=".uno:Underline"/> The command is also used on other toolbars and in other modules. Check https://opengrok.libreoffice.org/search?project=core&full=".uno%3AUnderlineSimple" to find all places. Please carefully consider if the simple command isn't better suited (not necessarily but possibly). (Note: .uno:UnderlineSimple has a target URL .uno:Underline while .uno:UnderlineSingle is another command. Quite confusing and worth to clean up.)
haru-02 committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aac980adda37cde886e43f12dc06d6a73cb6daa6 tdf#139701 change uno:UnderlineSimple to uno:Underline It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Solved. We have now arrow down in regular toolbar for underline. Verified in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 1a99b4e44190e182d56a04678850d62635d74c65 CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded