Bug 139724 - Tooltip for .uno:SetOutline should not be "Set Outline List Style" and name of "Outline" for .uno:OutlineFont should be differentiated
Summary: Tooltip for .uno:SetOutline should not be "Set Outline List Style" and name o...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: sdc.blanco
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: Bullet-Number-Outline-Lists
  Show dependency treegraph
 
Reported: 2021-01-18 02:18 UTC by sdc.blanco
Modified: 2021-12-14 12:41 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2021-01-18 02:18:12 UTC
In Formatting toolbar, make "Outline" visible. Look at tooltip.

Actual: "Set Outline List Style"

Should be:  "Set Outline Style"  or "Select Outline Style" or even just "Select Outline"

Should not use "List Style"  as part of tooltip because:
   a. does not set a list style
   b. creates unnecessary confusion/connection with List Style
Comment 1 sdc.blanco 2021-01-29 14:10:31 UTC
As part of improving clarity and consistency of labelling for lists and list style, bug 139667, comment 16, raised a question about whether the "Outline" tab in "Bullets and Numbering" dialog should get a better label.

That tab corresponds to the "Outline" icon in the toolbar addressed in comment 0.  If the label of the "Outline" tab is changed, then this will have consequences for the icon label for .uno:SetOutline. (have expanded bug summary accordingly)
Comment 2 sdc.blanco 2021-02-04 03:20:15 UTC
Tooltip for icon should be:

"Select Outline Format"

(or possibly "Select Outline Type" )

Label (for Customize) should be "Outline Format"  (or Outline Type)
Comment 3 sdc.blanco 2021-02-04 03:31:40 UTC
afaict, :uno:SetOutline can only be used on a toolbar.

Customizing it into a menu or shortcut key did not give any obvious effect.

Could consider hiding this control from Customize.  

It is already included as a (non-visible) option in the Formatting bar, so it could be made available on a toolbar.  And it is always available in the Bullets and Numbering dialog.
Comment 4 Heiko Tietze 2021-02-05 09:04:42 UTC
"Set Outline List Style" is the tooltip of .uno:SetOutline that also has its place in the textobjectbar. I agree with removing "List" and whether "Set Outline Style" or "Select Outline Format" is bike-shedding. The first one is closer to what we have and has less implications for l10n. 

Stumbled first over the other Outline button, which is the "outline font effect" and directly applied to the selection. The command is .uno:OutlineFont with no extra tooltip defined in GenericCommands.
Comment 5 sdc.blanco 2021-02-05 10:08:12 UTC
(In reply to Heiko Tietze from comment #4)
> "Set Outline Style" or "Select Outline Format" is bike-shedding. The first 
> one is closer to what we have and has less implications for l10n. 
Arguments for "Select" over "Set": 
   - afaict .uno:SetOutline command is only used on tb and only opens a 
     dialog where one has to "Select" an outline.
   - In the Bullets and Numbering dialog, Outline tab has the label 
      "Selection" over the the different outlines.

Arguments for "Format" over "Style"
   - "Style" should only be used to refer to LO styles.
   - "Outline style" in CSS refers the border drawn around an element
   - more common to find the expression "Outline Format" used in academic 
     contexts and professional organizations.

What are the l10n implications?

> Stumbled first over the other Outline button, which is the "outline font
> effect" and directly applied to the selection. The command is
> .uno:OutlineFont with no extra tooltip defined in GenericCommands.
File a new ticket?  
Or just add tooltip: Apply outline attribute to font
and change label to: Outline Font Effect

"Stumbled over" suggests Customize dialog.
What about question in comment 3 about hiding .uno:SetOutline from Customize dialog?  (iiuc, it is not possible to restrict its appearance to be solely in Toolbar, which is the only place where it is functional)
Comment 6 Heiko Tietze 2021-02-05 10:37:28 UTC
(In reply to sdc.blanco from comment #5)
> What are the l10n implications?

More confusion/work. The closer terms are the easier is to adjust the translation. But you have good arguments, so go ahead. 

> File a new ticket?  

Not necessary in this case.
Comment 7 sdc.blanco 2021-02-06 20:12:25 UTC
Here is a patch for .uno:SetOutline and .uno:OutlineFont

https://gerrit.libreoffice.org/c/core/+/110436
Comment 8 Commit Notification 2021-02-08 21:20:18 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/07d166a81c4287862180bba33cd6259262260ef1

tdf#139724 differentiate / improve labels on two "Outline" .unos

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 sdc.blanco 2021-02-08 21:23:00 UTC
Changed summary to correspond to what was fixed.
Comment 10 Stéphane Guillou (stragu) 2021-12-14 12:41:40 UTC
Verified as fixed in:

Version: 7.2.4.1 / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded