Bug 139735 - "Links to External Files" is not precise
Summary: "Links to External Files" is not precise
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks:
 
Reported: 2021-01-18 09:52 UTC by Mike Kaganski
Modified: 2022-11-15 08:40 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2021-01-18 09:52:22 UTC
tdf#91781, tdf#91820, tdf#91857 has changed menu item "Links..." into "Links to External Files..." - see https://git.libreoffice.org/core/+/67d245adca298134fc8ab4364acbe880b4e0911a, https://git.libreoffice.org/core/+/41e71a7c6f10eeca0d7bc083fc68dc85d9f2a986, https://git.libreoffice.org/core/+/7c6117780a8feb0b4ffcbaeaf649f4f6bc8470ec. However, that is not a correct text, because the links are not necessarily to *files*, but rather to *data* (e.g., it may be DDE getting information from running some application, or an URL to some dynamically-generated data).

It might be not a big issue, but still having imprecise names where we easily can have a better match would be good IMO.

Proposals: "External Links..." or "Links to External Data...".

Code pointers:
officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu
officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
Comment 1 Heiko Tietze 2021-01-20 14:25:16 UTC
Seth, one for you?
Comment 2 Heiko Tietze 2021-02-04 08:25:44 UTC
Sascha agrees and suggests "Externally Linked..." or "Linked Data and Files..."

We have
* Calc: .uno:InsertExternalDataSource "Link to E~xternal Data..."
* Draw/Impress: .uno:ManageLinks "Lin~ks to External Files..."
* Writer: .uno:LinkDialog "Lin~ks to External Files..."
  + cui/uiconfig/ui/baselinksdialog.ui is titled "Edit Links"
   
Streams are rather a corner case for Writer and DrawImpress but if "data" is read similar to "file" we should harmonize according Calc.

Documentation under https://help.libreoffice.org/7.0/en-US/text/shared/01/02180000.html is outdated.
Comment 3 Commit Notification 2022-01-24 12:02:01 UTC
Jeff Huang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6ff04de38652d639694489f9dc8e58c7039e067d

tdf#139735 Change "Links to External Files" to more precise sentence.

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Buovjaga 2022-01-24 12:07:56 UTC
Jeff: would you also like to change the help files:

source/text/scalc/00/00000404.xhp: <paragraph role="paragraph" id="par_id3146776" xml-lang="en-US"><variable id="eiextdata">Choose <menuitem>Sheet - Link to External Data</menuitem>.</variable></paragraph>
source/text/scalc/01/04090000.xhp:         <title xml-lang="en-US" id="tit">Link to External Data</title>
source/text/scalc/01/04090000.xhp: <paragraph xml-lang="en-US" id="hd_id3145785" role="heading" level="1"><link href="text/scalc/01/04090000.xhp" name="External Data">Link to External Data</link></paragraph>
source/text/scalc/guide/cellreferences_url.xhp:<paragraph xml-lang="en-US" id="par_id3145384" role="listitem">Choose <item type="menuitem">Sheet - Link to External Data</item>. The <link href="text/scalc/01/04090000.xhp" name="External Data"><item type="menuitem">External Data</item></link> dialog appears.</paragraph>
source/text/scalc/guide/webquery.xhp: <paragraph role="listitem" id="par_id3145750" xml-lang="en-US">Choose <emph>Sheet - Link to External Data</emph>. This opens the <link href="text/scalc/01/04090000.xhp">External Data</link> dialog.</paragraph>
source/text/shared/01/02180000.xhp: <paragraph role="paragraph" id="par_id271603459179173">This command can be used with external file links to <switchinline select="appl"><caseinline  select="WRITER">sections (place cursor outside of the section), master documents,</caseinline><caseinline select="CALC">sheets linked with <menuitem>Sheet - Insert Sheet from File</menuitem> or <menuitem>Sheet - Link to External Data</menuitem>, Function WEBSERVICE,</caseinline></switchinline> images and OLE objects (when inserted with a link to an external file).</paragraph>
Comment 5 Po-Yen Huang 2022-01-25 03:15:39 UTC
(In reply to Buovjaga from comment #4)
> Jeff: would you also like to change the help files:
> 
> source/text/scalc/00/00000404.xhp: <paragraph role="paragraph"
> id="par_id3146776" xml-lang="en-US"><variable id="eiextdata">Choose
> <menuitem>Sheet - Link to External Data</menuitem>.</variable></paragraph>
> source/text/scalc/01/04090000.xhp:         <title xml-lang="en-US"
> id="tit">Link to External Data</title>
> source/text/scalc/01/04090000.xhp: <paragraph xml-lang="en-US"
> id="hd_id3145785" role="heading" level="1"><link
> href="text/scalc/01/04090000.xhp" name="External Data">Link to External
> Data</link></paragraph>
> source/text/scalc/guide/cellreferences_url.xhp:<paragraph xml-lang="en-US"
> id="par_id3145384" role="listitem">Choose <item type="menuitem">Sheet - Link
> to External Data</item>. The <link href="text/scalc/01/04090000.xhp"
> name="External Data"><item type="menuitem">External Data</item></link>
> dialog appears.</paragraph>
> source/text/scalc/guide/webquery.xhp: <paragraph role="listitem"
> id="par_id3145750" xml-lang="en-US">Choose <emph>Sheet - Link to External
> Data</emph>. This opens the <link href="text/scalc/01/04090000.xhp">External
> Data</link> dialog.</paragraph>
> source/text/shared/01/02180000.xhp: <paragraph role="paragraph"
> id="par_id271603459179173">This command can be used with external file links
> to <switchinline select="appl"><caseinline  select="WRITER">sections (place
> cursor outside of the section), master documents,</caseinline><caseinline
> select="CALC">sheets linked with <menuitem>Sheet - Insert Sheet from
> File</menuitem> or <menuitem>Sheet - Link to External Data</menuitem>,
> Function WEBSERVICE,</caseinline></switchinline> images and OLE objects
> (when inserted with a link to an external file).</paragraph>

How can I push it to gerrit? I can't see logerrit script in https://gerrit.libreoffice.org/help
Comment 6 Heiko Tietze 2022-01-25 08:35:58 UTC
(In reply to Po-Yen Huang from comment #5)
> How can I push it to gerrit? I can't see logerrit script in

You need permission to submit. ESC decides who is allowed to based on past contributions. You patch has been submitted meanwhile, resolving the ticket as fixed. Many thanks for your work!
Comment 7 Po-Yen Huang 2022-01-25 08:39:45 UTC
(In reply to Heiko Tietze from comment #6)
> (In reply to Po-Yen Huang from comment #5)
> > How can I push it to gerrit? I can't see logerrit script in
> 
> You need permission to submit. ESC decides who is allowed to based on past
> contributions. You patch has been submitted meanwhile, resolving the ticket
> as fixed. Many thanks for your work!

So maybe I can't push patch for help content :-(
Comment 8 Heiko Tietze 2022-01-25 08:43:30 UTC
(In reply to Po-Yen Huang from comment #7)
> So maybe I can't push patch for help content :-(

You and everyone else can submit patches to Gerrit. Only the integration into the main repository (called master) is restricted.
Comment 9 Mike Kaganski 2022-01-25 08:49:07 UTC
(In reply to Heiko Tietze from comment #6)
> (In reply to Po-Yen Huang from comment #5)
> > How can I push it to gerrit? I can't see logerrit script in
> 
> You need permission to submit. ESC decides who is allowed to based on past
> contributions.

I am unsure if it's different in help, but I guess no special permissions are required to post to gerrit - be it core or help. logerrit is just a convenience wrapper around normal git commands; and it's mentioned in [1] that you may not use logerrit (see "Submitting patches as private or work-in-progress"). Just push to special gerrit branches: refs/for/<normal-branch-name>. So instead of

  logerrit submit master

you would do

  git push origin HEAD:refs/for/master

or somesuch.

Note also that you may use gerrit's Web UI to prepare and edit changes without even cloning source. Only the gerrit account is needed.

[1] https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch
Comment 10 Po-Yen Huang 2022-01-25 09:28:47 UTC
(In reply to Mike Kaganski from comment #9)
> (In reply to Heiko Tietze from comment #6)
> > (In reply to Po-Yen Huang from comment #5)
> > > How can I push it to gerrit? I can't see logerrit script in
> > 
> > You need permission to submit. ESC decides who is allowed to based on past
> > contributions.
> 
> I am unsure if it's different in help, but I guess no special permissions
> are required to post to gerrit - be it core or help. logerrit is just a
> convenience wrapper around normal git commands; and it's mentioned in [1]
> that you may not use logerrit (see "Submitting patches as private or
> work-in-progress"). Just push to special gerrit branches:
> refs/for/<normal-branch-name>. So instead of
> 
>   logerrit submit master
> 
> you would do
> 
>   git push origin HEAD:refs/for/master
> 
> or somesuch.
> 
> Note also that you may use gerrit's Web UI to prepare and edit changes
> without even cloning source. Only the gerrit account is needed.
> 
> [1] https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch

Done :-)
https://gerrit.libreoffice.org/c/help/+/128911
Comment 11 Commit Notification 2022-01-25 12:01:57 UTC
Jeff Huang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/798fa0b98aa4308d1082583966571d4de5f504bb

tdf#139735 Change all "Link to External Data" to "External Links"
Comment 12 JO3EMC 2022-04-28 06:45:12 UTC
This change changes the menu label in multiple components of LibreOffice (Writer, Calc, Impress, Draw), but it seems that the situation is different only in Calc.

In Writer, Impress, Draw, [Edit]> [Liks to External Files ...] in 7.3 was changed to [External Links ...] in 7.4. They open the Edit Links dialog.

On the other hand, for Calc, the [Edit]> [Liks to External Files ...] menu label with the same functionality remains unchanged in 7.4.

Instead, [Sheet]> [Links to External Data ...] in 7.3 has been changed to [External Links ...] in 7.4.
This menu opens the [External Data] dialog and has different functions from those under the [Edit] menu.

I don't think it's good that the situation is different only for Calc.
At least, shouldn't [Links to External Data ...] be reverted?

That being said, [External Liks ...] has the impression that it's hard to imagine the function because it's hard to understand what the link is to.
Comment 13 Mike Kaganski 2022-04-28 06:59:22 UTC
(In reply to JO3EMC from comment #12)
> On the other hand, for Calc, the [Edit]> [Liks to External Files ...] menu
> label with the same functionality remains unchanged in 7.4.

This means that commit 6ff04de38652d639694489f9dc8e58c7039e067d didn't fulfil its goal, and this is not fixed. Reopening.

> 
> Instead, [Sheet]> [Links to External Data ...] in 7.3 has been changed to
> [External Links ...] in 7.4.
> This menu opens the [External Data] dialog and has different functions from
> those under the [Edit] menu.
> 
> I don't think it's good that the situation is different only for Calc.
> At least, shouldn't [Links to External Data ...] be reverted?
> 
> That being said, [External Liks ...] has the impression that it's hard to
> imagine the function because it's hard to understand what the link is to.
Comment 14 Mike Kaganski 2022-04-28 07:04:17 UTC
Heh, sent too soon, didn't finish answering :)

(In reply to JO3EMC from comment #12)
> That being said, [External Liks ...] has the impression that it's hard to
> imagine the function because it's hard to understand what the link is to.

I find it hard to imagine a person who would find "external links" difficult, while *at the same time* "links to external files" would be fine. Whenever one works with anything external, IMO external links would be no worse from the intuition point of view. That said, links to external files would *definitely* confuse people who work with links to other types of external data.

Anyway, I might be wrong - but the speculation on that would require some quotation of a real user problem like "I can'r find a place to edit links to external files" - "that's in Edit->External Links" - "Ah - that's a confusing name; I couldn't guess that function could be hidden there".
Comment 15 JO3EMC 2022-04-30 12:03:53 UTC
Thanks to reopen.

"links to external files" may be a bit narrow.
I don't use any other spreadsheet software, so I don't know how this feature is often called in the world.
However, "external links" was intuitively associated with the kind of hyperlinks to me.
It may be just an impression.