Bug 139759 - Highlighting inside comments not shown for DOC/DOCX
Summary: Highlighting inside comments not shown for DOC/DOCX
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks: DOCX-Comments Highlight-Color
  Show dependency treegraph
 
Reported: 2021-01-19 09:23 UTC by Telesto
Modified: 2022-07-20 14:05 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (8.41 KB, application/vnd.oasis.opendocument.text)
2021-01-19 09:24 UTC, Telesto
Details
Example docx from Word 2013 (13.75 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-01-19 15:45 UTC, NISZ LibreOffice Team
Details
Example docx in Word and Writer master (195.75 KB, image/png)
2021-01-19 15:47 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-01-19 09:23:44 UTC
Description:
Highlighting inside comments not shown for DOC/DOCX

Steps to Reproduce:
1. Open the attached file
2. Save as DOCX/DOC
3. File reload

Also happening with DOC created in Word


Actual Results:
Highlighting lost..

Expected Results:
Should be shown


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: f2171af6ce3516598d9f8bac8294025a21a5b1a2
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-01-19 09:24:10 UTC
Created attachment 169005 [details]
Example file
Comment 2 Telesto 2021-01-19 09:25:46 UTC
As NISZ might care about this.. 

Support for highlighting in comments has been added for ODT with 4.4.0. UI wise is bit of mess: bug 85592
Comment 3 NISZ LibreOffice Team 2021-01-19 15:45:04 UTC
Created attachment 169020 [details]
Example docx from Word 2013

This is supported in Word / docx. Looks like a simple import+export bug.
Comment 4 NISZ LibreOffice Team 2021-01-19 15:47:01 UTC
Created attachment 169021 [details]
Example docx in Word and Writer master

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2081eac430ac69619149e44b453a2d7dda41fc83
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL
Comment 5 Aron Budea 2021-07-31 14:17:16 UTC
Already in LO 3.3.0.
Comment 6 Justin L 2022-07-13 17:25:32 UTC
Proposed import fix at http://gerrit.libreoffice.org/c/core/+/137036

So far I have no idea why highlighting isn't exporting. It doesn't even seem to be trying, and doesn't even recognize the attribute exists?
Comment 7 Commit Notification 2022-07-13 19:10:11 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fc8b757dad5d98f4ba1cd40d03505873128670cd

tdf#139759 writerfilter: import comment highlight

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-07-14 20:52:46 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/11937a68aecb8db9aebb1c929d940c5b85a0ecec

tdf#139759 sw ms-formats: export comment char background

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-07-15 11:42:13 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/386a9fadffa446caf40fd4f40b865c8c9432fa27

tdf#139759 writerfilter: avoid exception importing w:shd in comments

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Justin L 2022-07-15 12:22:56 UTC
This is fixed for DOCX and RTF. Export to DOC is OK - but still missing DOC import for both highlight and shade, and not sure why.
Comment 11 Commit Notification 2022-07-20 12:40:21 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b4c55cb614ae1601d7cae4bc87aca3d5396c1598

tdf#139759 doc import: import comment highlight/shade

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.