Bug 139774 - Combobox icon in right click form menu use List Box icon
Summary: Combobox icon in right click form menu use List Box icon
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.2.0 target:7.1.1 target:7.0.5
Keywords:
Depends on:
Blocks: Icon-Themes-Code
  Show dependency treegraph
 
Reported: 2021-01-19 23:03 UTC by Rizal Muttaqin
Modified: 2021-01-25 21:04 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Combo box icon use List box within right click menu with various icon theme (94.33 KB, image/png)
2021-01-19 23:03 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2021-01-19 23:03:36 UTC
Created attachment 169028 [details]
Combo box icon use List box within right click menu with various icon theme

Step to Reproduce

1. Open Writer
2. Insert a Form other than List box and Combox box (e.g Push Button from menu Form > Push Button)
3. Right Click on the Form > Replace with

Under the Replace with submenu, Combo box make use List box icon. This bug is icon theme independent, whatever the icon theme, the issue persist. I am sure something should be changed in code.

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 56f26399df894d05f24874a3cdc90694158e03bc
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-01-16_03:41:06
Calc: threaded


Version: 7.0.4.2
Build ID: 00(Build:2)
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: id-ID
Ubuntu package version: 1:7.0.4~rc2-0ubuntu0.20.04.2
Calc: threaded
Comment 1 Rizal Muttaqin 2021-01-19 23:07:31 UTC
Guess the icon defined by this line in two files:

#define RID_SVXBMP_COMBOBOX "res/sx10600.png"

https://opengrok.libreoffice.org/xref/core/framework/inc/bitmaps.hlst
https://opengrok.libreoffice.org/xref/core/framework/inc/bitmaps.hlst

Can someone validate this?
Comment 2 Rizal Muttaqin 2021-01-19 23:10:18 UTC
(In reply to Rizal Muttaqin from comment #1)
> Guess the icon defined by this line in two files:
> 
> #define RID_SVXBMP_COMBOBOX "res/sx10600.png"
> 
> https://opengrok.libreoffice.org/xref/core/framework/inc/bitmaps.hlst
> https://opengrok.libreoffice.org/xref/core/framework/inc/bitmaps.hlst
> 
> Can someone validate this?

Sorry, I mean one file (https://opengrok.libreoffice.org/xref/core/framework/inc/bitmaps.hlst)

Will send a patch, by God will
Comment 3 Commit Notification 2021-01-20 03:55:26 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3d3a0c412500a2b57ff1d49f05506ee62ef9d4c7

tdf#139774 fix wrong use List Box icon in Combo Box right click menu

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Rizal Muttaqin 2021-01-22 22:31:12 UTC
Fixed in 

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 1ef6d9ede57df21a975a8554f3f967adc5876f73
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-01-21_18:31:52
Calc: threaded
Comment 5 Commit Notification 2021-01-24 06:53:55 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/735cb2d0bd41e24e7b8336b9abbba258901e6c8b

tdf#139774 fix wrong use List Box icon in Combo Box right click menu

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-01-24 06:55:07 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/ebd57fe66e2150522e796ebfafe58bbb08dbfb8e

tdf#139774 fix wrong use List Box icon in Combo Box right click menu

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-01-24 19:12:43 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/53486257c0a3aaf5559d5f336db2e4245a33277f

similar to tdf#139774 for a combobox sx10601 is probably a better choice

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-01-25 06:12:55 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/96673ea050ac3299a543692b7a0d782794e3d2cd

similar to tdf#139774 for a combobox sx10601 is probably a better choice

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2021-01-25 21:04:11 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/ae2bf4d990fea469fed35ccf8048f5de96337896

similar to tdf#139774 for a combobox sx10601 is probably a better choice

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.