Bug 139788 - UI for Dark Mode visibility problems - elementary Icon Theme Has No Dark Variant
Summary: UI for Dark Mode visibility problems - elementary Icon Theme Has No Dark Variant
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.4.6.2 release
Hardware: All All
: low normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: UI-Theming Icon-Theme-Elementary
  Show dependency treegraph
 
Reported: 2021-01-20 16:48 UTC by bantairapper12345
Modified: 2022-02-21 14:53 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
This is how the Product Looks in dark theme (106.38 KB, image/png)
2021-01-20 16:51 UTC, bantairapper12345
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bantairapper12345 2021-01-20 16:48:47 UTC
Description:
When using LibreOffice Suite [Calc, Writer and all others], using them when Dark Theme is enabled in the system [I've tested in both Ubuntu and Linux Mint], Some of the Icons aren't visible and some of the icons in the toolbar. The icons which Include Letters like the ones for Bold Italic and Underline and also the ones for Allignments etc are in the default black color and hence, it raises visibility issues when used with the Dark Theme. 

You can see what I meant from this picture: 

https://drive.google.com/file/d/1rQwZsrSWxvohbYRc2iLljout1skfNfkV/view?usp=sharing 

It would be nice if it could be changed into some other contrasting color for the Dark Theme. 

Steps to Reproduce:
1.Change the icon image to a color which contrasts with black 
2.Colors like White/Yellow/Sandal would do good.
3.Detect the theme and if dark theme is enabled, use the White/Yellow/Sandal color icons and if Light Theme is enabled, use the current black icon sets itself.

Actual Results:
The icons will be clearly visible when the user uses a dark theme. 

Expected Results:
Changing of the Icon Color based on the Theme used by the user. 


Reproducible: Always


User Profile Reset: No



Additional Info:
If this is fixed, then it would cater to a better user experience.
Comment 1 bantairapper12345 2021-01-20 16:51:34 UTC
Created attachment 169057 [details]
This is how the Product Looks in dark theme

Would be better if the color of the icons for The Sort, Format, Bold, Italic, Underline and all other icons in the Tool Bar which are in the Black color changed into some other color which is contrast with black such as White or Sandal or Yellow.
Comment 2 mulla.tasanim 2021-01-22 16:09:07 UTC
Thank you for reporting the bug.

Enabling dark mode has visibility of icons.

for better visibility you can change Icon style, go to tools-options-view-icon style.

I can not reproduce the bug in,

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 3 Rizal Muttaqin 2021-01-31 08:51:57 UTC
Please keep in note that not every icon theme does support dark variant. You can use Sifr or Breeze theme for this purpose.
Comment 4 Timur 2021-03-23 18:07:49 UTC Comment hidden (obsolete)
Comment 5 Rizal Muttaqin 2021-03-25 04:06:50 UTC
This request can be a valid bug by renaming the title with "elementary Icon Theme Has No Dark Variant". As a maintainer of the icon theme, I have no plan for adding such variant as it would take another huge effort. At least by now. Everyone is welcomed to give the hand for this kind of request.
Comment 6 Timur 2021-03-25 06:41:43 UTC
Thanks Rizal, you could have changed it, I do it now, low priority.
Comment 7 Rizal Muttaqin 2022-02-21 14:53:34 UTC
I have requested a guidance from upstream

https://github.com/elementary/icons/issues/1086