Description: Several of the options appearing on the Windows 10 LO sidebar in Draw either make absolutely no sense with other options selected, or become unreachable because they're pushed down below the point of being visible. For example, a gradient for a background is mutually exclusive of having an image for a background, yet the Insert Image option remains enabled/visible when the background is selected to gradient, and the act of selecting a gradient makes part of the interface unreachable. Steps to Reproduce: 1. Launch Windows LibreOffice Draw 2. On the sidebar properties for the page, select Gradient Actual Results: The Insert Image option is still enabled/visible although Insert bitmap serves no purpose when the background is a gradient. Expected Results: 1. When Gradient is selected for a page background, the Insert Image option either disables or hides 2. No part of the interface should disappear below the visible clipping region for controls appearing/disappearing. 3.Attempting to use Insert Image when Gradient is selected changes the background option to bitmap. This is backward. The option selected should determine what parts of the interface enable/appear to support the selected option. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6ee7a3b2c0565c2871d32d704cb2899445b9f88d CPU threads: 8; OS: Windows 10.0 Build 21292; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL
Created attachment 169075 [details] sidebar
No, the intended function is to provide the image background preferentially. The 'Insert Picture...' dialog control is intentionally present with *each* of the Background types--its button is clipped for the Gradient selection only bcz the gradient has both a start and an end color pick. The gradient mode needs a few more pixels. Otherwise, a simple viusal glitch that does not affect function in *any* way. It may or may not show full button in macOS or one of the Linux backends.
(In reply to V Stuart Foote from comment #2) > No, the intended function is to provide the image background preferentially. > > The 'Insert Picture...' dialog control is intentionally present with *each* > of the Background types--its button is clipped for the Gradient selection > only bcz the gradient has both a start and an end color pick. The gradient > mode needs a few more pixels. > > Otherwise, a simple viusal glitch that does not affect function in *any* > way. > > It may or may not show full button in macOS or one of the Linux backends. Selecting gradient also hides the margin and master page controls.
Can't find an issue with the design but some more spacing would be nice anyway. Meaning everything is now in one grid with 3pt spacing but could separated before Insert Image getting also more spacing. What do you think, Andreas?
Code pointer is sd/uiconfig/simpress/ui/sidebarslidebackground.ui
(In reply to Heiko Tietze from comment #5) > Code pointer is sd/uiconfig/simpress/ui/sidebarslidebackground.ui fix this bug has to be done somewhere else not in the .ui file.
Don't see an issue with kf5 and gen on Linux. Probably a Windows only issue. Or fixed. Please check with latest build.
had the issue with gtk3 backend.
Having similar issue with 'color' drop down.. at page Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 28555fc345ac2ccdda0e4e0f3c812c646befe68b CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Created attachment 169966 [details] three panel clips showing default page 'Styles' CP and 'Background' list box It is still present in Windows builds. But it is not simply too few pixels, the CP does not resize to hold all the controls for the 'Gradient' background list box. Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 385808a2dff7300ec0120fdd5e8acfad8f86e50d CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Seems a functional glitch in the auto sizing of the SB Content Panel(s). attached shows height does not adjust when changing the 'Styles' CP 'Background' list box from default 'none' to 'gradient'. The extra controls needed for the gradient Layout: and Columns: do not fit. Final panel shows that collapsing and reopening the 'Styles' CP recalculates the correct height needed to show all the controls. @Heiko, please recheck.
Button cut-off seems to be present on win and gtk3, not kf5 and gen. And I agree that hiding the Insert Image button makes sense for other options than image as background; otherwise the whole dropdown i9s pointless.
I would call this ALMOST fixed. What happens now is that the controls are still cut off as before, until you select another object and then deselect that object. The sidebar then redraws, and all expected controls on the sidebar are then visible. Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 07996bcca53939af02921a3d4681c6c7d62a0e40 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL
(In reply to mwtjunkmail from comment #12) > I would call this ALMOST fixed. What happens now is that the controls are > still cut off as before, until you select another object and then deselect > that object. The sidebar then redraws, and all expected controls on the > sidebar are then visible. > > Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community > Build ID: 07996bcca53939af02921a3d4681c6c7d62a0e40 > CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: > win > Locale: en-US (en_US); UI: en-US > Calc: CL Still a bug in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 41145efffe9d5af358a52b9e114bb01b98b3d7c2 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL
Still a problem in Version: 7.2.0.0.alpha1 (x64) / LibreOffice Community Build ID: 94c1521be4ef12f195d08413d5e2134e07a49f85 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL
Caolan, this sidebar panel dynamically shows comboboxes. The initial state is with less items than later; but showing the items does not trigger resize (if I resize manually the controls become aligned as expected). Tried to solve with queue_resize(); at void SlideBackground::Update() but no success. You surely have a tip how to solve this issue. But this would be a band-aid and maybe resize() is better triggered somewhere else. sd/source/ui/sidebar/SlideBackground.cxx sd/uiconfig/simpress/ui/sidebarslidebackground.ui
Still a problem in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: e642179f466c899365fc9539a8aca66b39fea39a CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL
Created attachment 174129 [details] Screenshot
I think comments 1-10 are a duplicate of bug 143795 and #10 demos that writer has a similar panel with a similar problem which I'll fix under this id
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ebe01a5f019c6da1aa0dcb46213055f9f8cfdb7b tdf#139811 trigger layout when content changes It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I believe fixed in trunk, backports to 7-2 and 7-1 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/3c2ba16ecdcb5584fbb857d92ce5643db867be18 tdf#139811 trigger layout when content changes It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/420fa261a1bb5db9c6367cd4bbf9984c79b296cc tdf#139811 trigger layout when content changes It will be available in 7.1.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Works for me in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 5aac78e5fb241050a86714687e9ff8804588ae3c CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL