Bug 139953 - [rfe]: Tools > AutoCorrect > Apply and Edit Changes - drop first dialog go directly to Edit
Summary: [rfe]: Tools > AutoCorrect > Apply and Edit Changes - drop first dialog go di...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2021-01-28 01:34 UTC by sdc.blanco
Modified: 2023-01-03 17:45 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2021-01-28 01:34:40 UTC
1. Tools > AutoCorrect > Apply and Edit Changes

Actual: 
  Dialog box with: "Edit Changes" "Accept All" "Reject All"

Expected:
  Opens "Edit Changes" dialog directly.
Comment 1 Heiko Tietze 2022-04-05 09:46:15 UTC
Testing with "SHe heard *quiet* steps behind him. that didnt bode well." none Edit, Accept or Reject works for me in any language setting. Neither does "1st <<test>>" after unchecking the T in localized options.

What I expect after reading the help [1] is to get "She heard <b>quiet</b> steps behind him. That didn't bode well." with change tracking. And per Edit I get every single modification, per Accept all, and Reject the opposite. 

So removing the dialog wouldn't be an option. But I might be wrong.

[1] https://help.libreoffice.org/7.3/en-US/text/swriter/01/05150300.html
Comment 2 sdc.blanco 2022-04-05 10:28:41 UTC
(In reply to Heiko Tietze from comment #1)
> So removing the dialog wouldn't be an option.
Agree.  Elaboration of terse OP to remove one step in the dialog (and independent of current Autocorrect behavior)


Current workflow:

1. Tools > Autocorrect > Apply and Edit Changes
2. Dialog box (with buttons for Edit Changes, Accept All, Reject All)
3. Choose Edit Changes 
4. another dialog box opens -- with Accept All and Reject All at the bottom.

Comments: 
- The menu command was Apply and Edit Changes, why should I have to click another dialog box to be able to Edit Changes, when I just selected it in the menu?
- Although the first dialog box offers Accept All and Reject All, so does the second dialog box, plus I get to see what I am accepting and rejecting, rather than doing it blind.
- If only the second dialog box comes up directly from the menu command (including the Accept All and Reject All on the bottom) then I can still  Accept/Reject All directly and quickly.

Therefore: Proposed workflow.

1. Tools > Autocorrect > Apply and Edit Changes
4. Dialog box opens -- with Accept All and Reject All at the bottom.
Comment 3 sdc.blanco 2022-04-05 10:36:58 UTC Comment hidden (off-topic)
Comment 4 sdc.blanco 2022-04-05 11:26:05 UTC Comment hidden (off-topic)
Comment 5 Heiko Tietze 2022-04-05 11:32:46 UTC
(In reply to sdc.blanco from comment #3)
> Did you use "Default Paragraph Style"?

Haven't touched the PS but running the test again now works as expected with Default PS. 

Question remains whether to remove the shortcut to Accept/Reject. No strong opinion from my side.
Comment 6 Heiko Tietze 2022-04-14 12:27:17 UTC
Topic was on the agenda for the design meeting but didn't receive further input.

I agree with the idea, let's do it.

Code pointer:
sw/source/uibase/shells/textsh1.cxx: 
* switch (lcl_AskRedlineFlags(GetView().GetFrameWeld()))...
* static short lcl_AskRedlineFlags(weld::Window *pWin)
sw/uiconfig/swriter/ui/queryredlinedialog.ui
sw/UIConfig_swriter.mk
Comment 7 Commit Notification 2022-07-07 07:42:27 UTC
Aman Jha committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3bf537244973a19c09dc6ef6430e25a05ba5027f

tdf#139953 Apply and Edit Changes - drop first dialog go directly to Edit

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Stéphane Guillou (stragu) 2023-01-03 17:45:37 UTC
Fix verified in:

Version: 7.5.0.1 (X86_64) / LibreOffice Community
Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks everyone!